Need C program built

[SuperRocketMan]

Hello, So I'm messing around with the C language and I want to test out some things with arrays. Could someone help write a C program that allows the user to enter up to twenty non-negative integers and store them in an array. Print the numbers (one per line) in the same order they were entered. Then remove all the duplicate numbers from the list and print the numbers with the duplicates removed. Then sort the numbers into ascending order using a bubble sort and print the numbers with the numbers sorted. I also want the user to indicate that all numbers have been entered by typing in a -1. Just trying to get a better understanding of arrays. This program is just for personal use. 

[NInety]

BS. You want us to do your homework.

[CornOnJacob]

Why don't you take a crack at it, post your attempt here, and then everyone can try to help make it better. Otherwise you've learned nothing and we did all the work.

[mkessler9]

Hello, So I'm messing around with the C language and I want to test out some things with arrays. Could someone help write a C program that allows the user to enter up to twenty non-negative integers and store them in an array. Print the numbers (one per line) in the same order they were entered. Then remove all the duplicate numbers from the list and print the numbers with the duplicates removed. Then sort the numbers into ascending order using a bubble sort and print the numbers with the numbers sorted. I also want the user to indicate that all numbers have been entered by typing in a -1. Just trying to get a better understanding of arrays. This program is just for personal use. 

You will never learn if you don't do your own homework!

[Ciccioo]

inb4 this http://linustechtips.com/main/topic/112673-can-anyone-help-me-finish-this/

[Flojer0]

The time spent banging your head against the wall is when you learn. Never mind that arrays are at the bottom of the ladder. I suggest you get off the hand holding as soon as possible, will make later concepts easier to swallow.

[SuperRocketMan]

Everyone chill out. this isn't BS. I'll post what I have soon

[nillas12]

The thing is, you only have 2 posts, the 2 posts on this topic, and quite honestly it seems like you just wanted people to make your homework for you. Now if you (as you are doing now, hopefully) gives us some of your work, and explains what you want it to do, and what you think the problem is, you'll see that people are more likely to actually help you out.

[MG2R]

Please refer to this post on how to make these kinds of threads...

 

People using the night theme can see when text is copy-pasted, because that text is actually hard-formatted in black, instead of switching to white in a dark theme. Couple the fact that you just copied this thread with the fact that you made an account simply to get us to do your homework will make people reluctant to help you out.

 

If you try again according to the post mentioned above, maybe we can talk.

[SuperRocketMan]

I made this account because I forgot my other account and I deactivated the email associated with it. Here is the code I worked on and could use some help. http://pastebin.com/JYrVcJkV

 

Okay I'm having trouble in my output. If I enter in 20 numbers the program performs and under the "numbers you entered" list the last number is always removed(Unless i type in a -1 before I type in all 20 numbers then it works) why is the last number getting removed under that section. The list with the duplicates removed seems to work. Also I'm very confused on how to create a bubble sort. Anyways sry for the badly worded post. I really just need help. ty

[WanderingFool]

I made this account because I forgot my other account and I deactivated the email associated with it. Here is the code I worked on and could use some help. http://pastebin.com/JYrVcJkV

 

Okay I'm having trouble in my output. If I enter in 20 numbers the program performs and under the "numbers you entered" list the last number is always removed(Unless i type in a -1 before I type in all 20 numbers then it works) why is the last number getting removed under that section. The list with the duplicates removed seems to work. Also I'm very confused on how to create a bubble sort. Anyways sry for the badly worded post. I really just need help. tyr

Lot better of a post

 

Anyways, the issue is the way you are going through your indices (indexes?)

 

Look at this line

for (i=0; i < count; i++)

This is where you are getting your input...I am guessing you actually must have i < 20 or something else like that (as count = 0 was set initially without changing it)...anyways I am assuming that you input for loop runs correctly given your current problem.  So with that running correctly look at this line

for(i=1;i<count;++i)

Now you are going from 1 to (count-1)....this is a problem as count = 20 will only display 19 numbers.  The thing to note is you are using nums[i-1], but if count is lets say 5 you will only display 4 numbers....so really you want i<=count...or the more conventional way

for(i=0;i<count;++i)

and then just use nums

 

I am a bit tired right now so I never really looked over the rest of your code though...if I get time tomorrow I might

[SuperRocketMan]

Cool I try some of your tips when I get home I'm at work. I'll update later tonight. If anyone else has any input/suggestions or help pls jump in! 

[SuperRocketMan]

So I did what you said and it worked!! tysm but Now I'm confused on how I can sort the numbers into ascending order using a bubble sort

[SuperRocketMan]

So I'm having trouble with trying to print the numbers in ascending order using a bubble sort. I just tried to type one up but I don't think I'm right and when I ran it nothing happens under the ascending section. Here's my code:

 

 

printf("\n Your numbers sorted in to ascending order:\n");

 

    for(i=0; i<count; i++)

    {

    for(j=0;j<count;i++)

    {

    if(nums[j]>nums[j+1])

    {

    temp=nums[j];

    nums [j] =nums[j+1];

    nums [j+1] =temp;

    }

 

    }

    }

 

    for(i=0;i<count;i++)

    {

printf("%d\n" , nums[j]);

    }

[WanderingFool]

Okay, there are a few things wrong with your current sorting algorithm.

 

The one of the most glaring problems I can see is the "j+1" problem.  First j goes from 0 to count, so doing +1 will mean you access count+1 which should not exist (So it would mean j should go from 0 to count-1 instead).

The second of the glaring problems is you used j instead of i while printing out nums....that will be a problem

Finally, the beauty of the bubble sort is it requires at slightly less than n² comparisons (but classified as O(n²)...the way you have it now, it will always do n² comparisons though.  After you have initially sorted the first element, the last element in the array will be in the correct location.  So instead of going each time to he end of the array you could do one less comparison.  That would make your j for loop look like this (if my logic is right)

for(j=0;j<count - i - 1;i++)

[MG2R]

 

Finally, the beauty of the bubble sort is it requires at slightly less than n² comparisons (but classified as O(n²)...the way you have it now, it will always do n² comparisons though.  After you have initially sorted the first element, the last element in the array will be in the correct location.  So instead of going each time to he end of the array you could do one less comparison.  

 

This is also explained in this video: