Noob seeking a troubleshoot?

[Rossyboy]

hi all, 

 

Im sorry to have to make this post and bother everyone but I've really exhausted myself trying to find the solution here with no avail.

 

Basically, I'm new to C++ and I'm trying to wrap my head around this "classes" idea. I made a silly little console window program just to try and teach myself it but every time I compile I get this error

 

error C2228: left of '.ratedance' must have class/struct/union

 

heres my program

#include "stdafx.h"#include <iostream>#include <string>using namespace std;class Josh{	Josh (int assiage, int assistyle):	age(assiage),	style(assistyle)	{	}public:		void ratedance();private:	int age;	int style;};int main(){	int ch1, ch2;	cout << "what is his age?" << endl;	cin >> ch1;	cout << "what is his style rating?" << endl;	cin >> ch2;	Josh dude(int ch1, int ch2);	dude.ratedance();	char f;	cin >> f;	return 0;}void Josh::ratedance(){	if (age < 18 && style > 5)	{		cout << "this josh has excellent dance moves" << endl;	}	if (age > 18 && style < 5)	{		cout << "meh" << endl;	}	else 	{	}}

 

I know there's just some silly little detail I'm missing but I can't seem to see it. 

 

Anyway I hope one of you wonderful people can help!

 

Thanks

Rossyboy

[LukeTim]

Your link isn't working, but it looks like you've just not properly instantiated a variable...

[squirrl]

You already declared ch1 and ch2 as int. You don't put a type when calling a method or constructor in this case at least.

Josh dude(int ch1, int ch2);

Should be:

Josh dude(ch1, ch2);

[Rossyboy]

Your link isn't working, but it looks like you've just not properly instantiated a variable...

Thanks for the reply. Sorted the link.

[squirrl]

Not sure if you've thought of it or not, but do you need something to happen if age == 18 and style == 5? (or age > 18 && style < 5 and age < 18 && style > 5)

[WanderingFool]

Rossyboy I think by correcting the int problem that squirrl mentioned should fix your problem.

 

The reason being that the issue Squirrl brings up makes dude an incorrect class, and then calling a method from Josh using dude means it can't properly detect the correct class.

 

With that said if correcting that issue doesn't work, try implementing the ratedance method prior to implementation of the main class (It shouldn't matter, but who knows...you usually don't define classes in cpp files, usually it is in header files and implementation goes in cpp files)

[Rossyboy]

Thanks for the help guys! I've made some simplifications to the code. I know that if I was doing this all properly the definitions ect would be in different files but this is only for experimental purposes.

 

Heres what Ive got now.

#include "stdafx.h"#include <iostream>#include <string>using namespace std;class Josh{	Josh (int assiage,  int assistyle):	age(assiage),	style(assistyle)	{		}public:		void ratedance()	{		if (age < 18 && style > 5)		{		cout << "this josh has excellent dance moves" << endl;		}		if (age > 18 && style < 5)		{		cout << "meh" << endl;		}	}	private:	int age;	int style;};int main(){	int ch1, ch2;	cout << "what is his age?" << endl;	cin >> ch1;	cout << "what is his style rating?" << endl;	cin >> ch2;	Josh dude(ch1,ch2);	dude.ratedance();	char f;	cin >> f;	return 0;} 

Unfortunately I'm getting a new error (error C2248: 'Josh::Josh' : cannot access private member declared in class 'Josh') Any ideas?

 

 

THANK YOU EVERYONE

[Nuluvius]

That is because you have made your constructor private. The default access level is private when undefined. Move your Josh constructor to the public block.

[Nuluvius]

Also considering your architecture, a couple of things came to mind; Isn't Josh a name for a Dude? What I'm trying to say is, wouldn't it make more sense if your class was called Dude and you instantiated against a variable named Josh. Or better yet you gave the Dude class another field called name which would be of the type string into which you passed "Josh" and instantiated against a person/dancer/contestant variable instead. The other thing is that you should really be declaring a class separately, granted you're learning but it's good to start with best practices; i.e. a header (.h) containing the declarations and an implementation (.cpp) containing just that, the implementation.

[Rossyboy]

Also considering your architecture, a couple of things came to mind; Isn't Josh a name for a Dude? What I'm trying to say is, wouldn't it make more sense if your class was called Dude and you instantiated against a variable named Josh. Or better yet you gave the Dude class another field called name which would be of the type string into which you passed "Josh" and instantiated against a person/dancer/contestant variable instead. The other thing is that you should really be declaring a class separately, granted you're learning but it's good to start with best practices; i.e. a header (.h) containing the declarations and an implementation (.cpp) containing just that, the implementation.

I know all these things. It was only a quick program, but thanks for your help