Help with C class please

[Ciccioo]

-snip-

indexOfLargest should return indLarge, not curr

curr will always return "numElements", which may make you access unallocated memory, which would cause crashes (and wrong random results)

[Ciccioo]

typing the previous post was the ultimate typo/error galore

i even ended up doubleposting

please someone delete this post

[joemomma22]

indexOfLargest should return indLarge, not curr

curr will always return "numElements", which may make you access unallocated memory, which would cause crashes (and wrong random results)

 

 

typing the previous post was the ultimate typo/error galore

i even ended up doubleposting

please someone delete this post

haha too late now.  xP and yeah changing curr to indlarge was kinda a duh moment. but its still crashing

[Ciccioo]

haha too late now.  xP and yeah changing curr to indlarge was kinda a duh moment. but its still crashing

it works for me

does Strings.dat exist?

 

debug it a bit, try removing function calls from the main until it stops crashing

and check what is returned by fopen: if it's NULL, then shit happened with your file

[Avratz]

If you are running it from within Code::Blocks, since you have a relative (working dir) path you need to set your project's working dir

 

Project -> Properties -> Build Targets tab

 

 

Set that to where ever your Strings.dat file is

[joemomma22]

it works for me

does Strings.dat exist?

 

debug it a bit, try removing function calls from the main until it stops crashing

and check what is returned by fopen: if it's NULL, then shit happened with your file

 

 

If you are running it from within Code::Blocks, since you have a relative (working dir) path you need to set your project's working dir

 

Project -> Properties -> Build Targets tab

 

 

Set that to where ever your Strings.dat file is

if i comment out the swap call in selSort it runs printing out the array file twice (obviously unsorted)

[Ciccioo]

if i comment out the swap call in selSort it runs printing out the array file twice (obviously unsorted)

are you sure you corrected the indexOfLargest thing? and recompiled?

[WanderingFool]

I think it might be an out of bounds error.

 

Consider the first swap

void selSort(char strings[][31], int count){    int loc;    int last = count;    for (last; last >= 1; --last)    {        loc = indexOfLargest(strings, last + 1);        swap(strings, loc, last); //So you are passing in the strings, location and for the first time last will = count    }}void swap(char strings[][31], int loc, int last){    char temp[31];    strcpy(temp, strings[loc]);    strcpy(strings[loc], strings[last]); //You are using last, but if last = count you are actually accessing the string one past the end of your array    strcpy(strings[last], temp); //So you need to correct for that, remember your index is from 0 to count-1}

[joemomma22]

I thank everyone again for all the help. I turned my lab in incomplete. I ended up with an a- in the class this is what brought it down from an a+ but that's okay