How would could I make this more compact or efficient?

[mbntr]

This is a test, I just started using python and I'm trying to find some useful-ish projects

 

import pytube as pt
import urllib.request
import urllib.parse
import datetime
from moviepy.video.io.VideoFileClip import VideoFileClip
import os
import shutil
import re

lis = []

tr = True

print("\nYouTube video Downloader v2.1 BETA\n")

print("----------------------------------------------------------------------------------------------------------------"
      "-----------")

print("Write the titles of the videos or you want to download, as if you were using the youtube search bar (you can "
      "also write the\nchannel name to download the newest video from said channel), after you have finished "
      "press enter twice, before that you\nwill have to clarify the directory you want the files downloaded to...\n")

dirn = input(r"Please enter the download directory, then press enter: ")

dat = datetime.datetime.now()

dirnam = "YouTube videos " + dat.strftime("%B %d %Y")

dir = os.path.join(dirn, dirnam)
dir2 = os.path.join(dir, "mp3")
dir3 = os.path.join(dir, "mp4")

os.mkdir(r"" + dir + "")
os.mkdir(r"" + dir3 + "")

aud = input("Do you want to download the videos in mp3 or in mp4? -write mp3 or mp4-\n")

if aud in "mp3":
    os.mkdir(r"" + dir2 + "")

else:
    pass

print("\n\nNow write the titles...")

while tr:
    inp = input()

    if inp != "":
        lis.append(inp)

    else:
        n = 0
        for a in range(int(len(lis))):
            query_string = urllib.parse.urlencode({"search_query": lis[n]})
            html_content = urllib.request.urlopen("http://www.youtube.com/results?" + query_string)
            search_results = re.findall(r'href=\"\/watch\?v=(.{11})', html_content.read().decode())
            inp = "http://www.youtube.com/watch?v=" + search_results[0]


            class Video_to_audio:
                def __init__(self, url):
                    self.url = url

                def convert(self):
                    vid = pt.YouTube(self.url)
                    stri = vid.streams.filter(file_extension='mp4').get_highest_resolution()
                    print("\nDowloading: ", vid.title, "| ", str(datetime.timedelta(seconds=vid.length)), "hours",
                          "| ", vid.views, " views", "| ", "rating ", vid.rating, "\n")
                    stri.download(dir)

                    if aud in 'mp3':
                        print("Converting file to mp3 format...")

                        if vid.title[-1] == "." or vid.title[-1] == "?":

                            try:
                                vod = vid.title[:-1]
                                clip = VideoFileClip(os.path.join(dir, vod) + ".mp4")
                                clip.audio.write_audiofile(os.path.join(dir, vod) + ".mp3")

                            except:
                                print("\nError converting file: " + vid.title + ".mp4")

                        else:

                            try:
                                clip = VideoFileClip(os.path.join(dir, vid.title) + ".mp4")
                                clip.audio.write_audiofile(os.path.join(dir, vid.title) + ".mp3")

                            except:
                                print("\nError converting file: " + vid.title + ".mp4")

                    elif aud in 'mp4':
                        pass

                    else:
                        print("\nNo type was specified, defaulting to mp4 ")


            video = Video_to_audio(inp)
            video.convert()
            n += 1
        try:
            files = os.listdir(dir)
            if aud in "mp3":

                for f in files:
                    if re.search(".mp3", f):
                        f = os.path.join(dir, f)
                        shutil.move(f, dir2)

                for f in files:
                    if re.findall(".mp4", f):
                        f = os.path.join(dir, f)
                        shutil.move(f, dir3)
            else:
                for f in files:
                    if re.search(".mp4", f):
                        f = os.path.join(dir, f)
                        shutil.move(f, dir3)
        except:
            print("An error occurred when moving files...")

        input("\nAll videos have been downloaded and converted, press ENTER to exit")
        break

I made this for my grandfather who wants to download songs to use in his stereo player in the car.

[Sauron]

12 minutes ago, mbntr said:

 

            files = os.listdir(dir)
            if aud in "mp3":

                for f in files:
                    if re.search(".mp3", f):
                        f = os.path.join(dir, f)
                        shutil.move(f, dir2)

                for f in files:
                    if re.findall(".mp4", f):
                        f = os.path.join(dir, f)
                        shutil.move(f, dir3)
            else:
                for f in files:
                    if re.search(".mp4", f):
                        f = os.path.join(dir, f)
                        shutil.move(f, dir3)

 

You can write that in a simpler way that doesn't make you loop twice for no reason:

            files = os.listdir(dir)
            for f in files:
            	if aud in "mp3":
                    if re.search(".mp3", f):
                        f = os.path.join(dir, f)
                        shutil.move(f, dir2)
                if re.search(".mp4", f):
                    f = os.path.join(dir, f)
                    shutil.move(f, dir3)

 

Also I don't understand why you're defining a class and why you're doing it inside a loop - that's both unnecessary and incredibly inefficient. If you want a class for whatever reason just define it at the start instead of redefining it at every loop iteration.

[mbntr]

2 minutes ago, Sauron said:

You can write that in a simpler way that doesn't make you loop twice for no reason:

            files = os.listdir(dir)
            for f in files:
            	if aud in "mp3":
                    if re.search(".mp3", f):
                        f = os.path.join(dir, f)
                        shutil.move(f, dir2)
                if re.search(".mp4", f):
                    f = os.path.join(dir, f)
                    shutil.move(f, dir3)

 

Also I don't understand why you're defining a class and why you're doing it inside a loop - that's both unnecessary and incredibly inefficient. If you want a class for whatever reason just define it at the start instead of redefining it at every loop iteration.

good question, why did I do that... I could have used a function too.

How could I do it without the loop?

[Sauron]

12 minutes ago, mbntr said:

good question, why did I do that... I could have used a function too.

How could I do it without the loop?

I can't tell if you need the while loop because you didn't comment anything but the declaration of the class or function can be done at the top of the file, right after the imports - that way it's done once (which is all you need) and then you can just call it inside the loop.