What is the problem in this python code

[TheGrim123321]

I'm very new to python so I figured I'd try to write a simple calculator that only does addition (I'm new give me a break)

 

Code

number_1 = input('Enter a number: ')
number_2 = input('Enter a second number: ')
addition = 1
function = func (input('1. Addition'))
if func = 1
    print "number_1 + number_2"

 

Error

 

 if func = 1
            ^
SyntaxError: invalid syntax

Process finished with exit code 1

 

Plz help

 

[SSL]

Equality operator is not a single "="

[TheGrim123321]

1 minute ago, SSL said:

Equality operator is not a single "="

I tried 2 == same error

 

I"m using pycharm

[Silencer]

It should be ==

[Nineshadow]

And it should be :

if func == 1 :
	print <etc>

With ":"

[SSL]

1 minute ago, TheGrim123321 said:

I tried 2 == same error

 

I"m using pycharm

 

func doesn't look like a valid identifier. Should it be function?

[TheGrim123321]

As of right now I'm

number_1 = input('Enter a number: ')
number_2 = input('Enter a second number: ')
additon = 1
function = (input('1. Addition'))
if input == 1 :
   print ("number_1 + number_2")

however it's not printing. I'm not getting an error code tho

[SSL]

2 minutes ago, TheGrim123321 said:

As of right now I'm

number_1 = input('Enter a number: ')
number_2 = input('Enter a second number: ')
additon = 1
function = (input('1. Addition'))
if input == 1 :
   print ("number_1 + number_2")

however it's not printing. I'm not getting an error code tho

 

input is a reserved word. You can't use it as a variable name.

[Beskamir]

So what's input in this case? You never define input as 1 do you? Also (I think) input() gets the user input as a string so you may have to convert them to ints first.

[TheGrim123321]

1 minute ago, ElfFriend said:

So what's input in this case? You never define input as 1 do you? Also (I think) input() gets the user input as a string so you may have to convert them to ints first.

How do I do that

I'm extremely knew to python and programming

[SSL]

Overall, it might be easier if you can give us the pseudo-code of what you are trying to accomplish, and how. As it is I'm kind of confused what you're trying to do.

[TheGrim123321]

4 minutes ago, SSL said:

 

input is a reserved word. You can't use it as a variable name.

That's what I was trying to use func as a var

[SSL]

1 minute ago, TheGrim123321 said:

That's what I was trying to use func as a var

 

But you weren't assigning "func" anywhere.

[Beskamir]

1 minute ago, TheGrim123321 said:

How do I do that

I'm extremely knew to python and programming

Converting from a string to an int can be done with newVaraible=int(oldVariable).

[Glenwing]

6 minutes ago, TheGrim123321 said:

As of right now I'm

number_1 = input('Enter a number: ')
number_2 = input('Enter a second number: ')
additon = 1
function = (input('1. Addition'))
if input == 1 :
   print ("number_1 + number_2")

however it's not printing. I'm not getting an error code tho

inputs are taken in as strings, so even if you type in "1", it'll be interpreted as the character "1", not the integer value of 1, thus "1" == 1 does not satisfy the equality, and the print statement is skipped. You need to either convert the input to an int, or compare it with the character "1" instead.

 

if int(input) == 1:
    print()

[or]

if input == '1':     #note the quotations around '1'
    print()

You will also need to convert number_1 and number_2 to ints in the same manner (int(input()) if you want to add them together, otherwise since they're strings right now, the addition operator will just combine them (i.e. if number_1 is set to "4" and number_2 is set to "8", they'll "add up" to 48).

[Beskamir]

3 minutes ago, Glenwing said:

inputs are taken in as strings, so even if you type in "1", it'll be interpreted as the character "1", not the integer value of 1, thus "1" == 1 does not satisfy the equality, and the print statement is skipped. You need to either convert the input to an int, or compare it with the character "1" instead.

 

if int(input) == 1:
    print()

[or]

if input == '1':     #note the quotations around '1'
    print()

You will also need to convert number_1 and number_2 to ints in the same manner (int(input()) if you want to add them together, otherwise since they're strings right now, the addition operator will just combine them (i.e. if number_1 is set to "4" and number_2 is set to "8", they'll "add up" to 48).

I generally rather test that the input can indeed be an int first since I've lost all trust in users at this point

[TheGrim123321]

4 minutes ago, SSL said:

Overall, it might be easier if you can give us the pseudo-code of what you are trying to accomplish, and how. As it is I'm kind of confused what you're trying to do.

number_1 = input('Enter a number: ')
number_2 = input('Enter a second number: ')
additon = 1
function = (input('1. Addition'))
if input == 1 :
   print ("number_1 + number_2")

 

Pseudo code

number_ 1 = user input

number_2 = user input

addition = 1

math = user input

if userinput = 1 then print number_1 + number_2

[SSL]

1 minute ago, TheGrim123321 said:

number_1 = input('Enter a number: ')
number_2 = input('Enter a second number: ')
additon = 1
function = (input('1. Addition'))
if input == 1 :
   print ("number_1 + number_2")

 

Pseudo code

number_ 1 = user input

number_2 = user input

addition = 1

math = user input

if userinput = 1 then print number_1 + number_2

 

What is the "addition" variable for?

[Beskamir]

okay so what's the point of addition = 1? You don't seem to use it for anything? Same with math

[SSL]

Also, you can't do string interpolation like you are doing with "number_1 + number_2". That will literally print "number_1 + number_2".

[TheGrim123321]

2 minutes ago, ElfFriend said:

okay so what's the point of addition = 1? You don't seem to use it for anything? Same with math

 

2 minutes ago, SSL said:

 

What is the "addition" variable for?

So when the user types in 1 it knows its the addition variable should it be

if input == addition

 

should I turn

function = (input('1. Addition'))

 

into

 

input('1. Addition')

[TheGrim123321]

2 minutes ago, SSL said:

Also, you can't do string interpolation like you are doing with "number_1 + number_2". That will literally print "number_1 + number_2".

If I remove the " " will it print it right

[Beskamir]

Here's what I'd do:

number_1 = int(input('Enter a number: '))
number_2 = int(input('Enter a second number: '))
function = int(input('1. Addition'))
if function == 1 :
   print (number_1+number_2)

 

Edit: Actually I'd do it slightly cleaner (nicer prompts) but this should work...

[SSL]

4 minutes ago, TheGrim123321 said:

If I remove the " " will it print it right

 

Yes.

 

4 minutes ago, TheGrim123321 said:

 

So when the user types in 1 it knows its the addition variable should it be

if input == addition

 

should I turn

function = (input('1. Addition'))

 

into

 

input('1. Addition')

 

I think you should write out what you want to happen in plain English (or whatever language you prefer). Then translate that to Python. I could just tell you what to code, but I don't think will help you learn.

 

I will suggest that "operator" or "operation" would be a clearer variable name than "function".

[TheGrim123321]

3 minutes ago, ElfFriend said:

Here's what I'd do:

[code]
number_1 = int(input('Enter a number: '))
number_2 = int(input('Enter a second number: '))
function = int(input('1. Addition'))
if function == 1 :
   print (number_1+number_2)
[/code]

This works thank you