C# - Issue with Saving Images to PDF

[WelshDdraig]

Hi Everyone, 

 

I haven't done any programming for a while (like upwards of a year to a year and a half or so), and decided to try and make a program to convert a collection of images to a PDF.

The program should work - and I believe it will work, however - I seem to be having an issue when it comes to saving the file.

With my code, I can get the program to run and execute fine, but when I go to save the document with a SaveFileDialog, the document doesn't save.

I could be missing something extremely simple, but cannot seem to be able to figure it out. 

As such, I was hoping people on the forum might be able to help me out.

 

My program's concept was based around this video, but modified by me so I can see the images loaded in a ListBox and preview the image when clicked in a PictureBox (That bit works fine), using code from the link below the video.

Spoiler

ListBox/PicturBox Code: https://www.codeproject.com/Questions/897701/how-to-add-multiple-images-to-listbox-and-display

It's just the document saving/output I seem to be having. Unlike the example, I do not want to hard code a save path or file name, but use a SaveFileDialog. 
Just as a note, to do the PDF Conversion, I am using the PdfSharp library (like the one used in the video in the spoiler).

Here is my code:

Spoiler

namespace JPGtoPDFConverter
{
    public partial class Form1 : Form
    {
        string parentDir = "";
        PdfDocument document = new PdfDocument();

        public Form1()

        {
            InitializeComponent();
        }

        private void lstBox1_SelectedIndexChanged(object sender, EventArgs e)
        {
            string filename = System.IO.Path.Combine(parentDir, lstBox1.SelectedItem.ToString());
            pictureBox1.Image = Image.FromFile(filename);
        }

        private void bntOpenFiles_Click(object sender, EventArgs e)
        {
            using (OpenFileDialog dlg = new OpenFileDialog())
            {
                dlg.Filter = "";
                dlg.Title = "";
                dlg.Multiselect = true;

                var images = imageList1.Images;                

                DialogResult dr = dlg.ShowDialog(this);
                if (dr == DialogResult.OK)
                {
                    foreach (string file in dlg.FileNames)
                    {                        
                      lstBox1.Items.Add(file);
                      images.Add(Image.FromFile(file));

                     PdfPage page = document.AddPage();
                     XGraphics gfx = XGraphics.FromPdfPage(page);
                     DrawImage(gfx, file, 0, 0, (int)page.Width, (int)page.Height);

                    }
                }
            }           
        }

        void DrawImage(XGraphics gfx, string file, int x, int y, int width, int height)
        {
            XImage image = XImage.FromFile(file);
            gfx.DrawImage(image, x, y, width, height);
        }

        private void btnGenPDF_Click(object sender, EventArgs e)
        {            

            if (document.PageCount > 0)
            {

                SaveFileDialog saveFileDialog1 = new SaveFileDialog
                {
                    Filter = "PDF File|*.pdf",
                    Title = "Generate PDF"
                };                
            }
        }        
    }     
    
}

 

Thanks for your time and input. This issue is probably me being stupid...

[AbydosOne]

10 minutes ago, WelshDdraig said:

but when I go to save the document with a SaveFileDialog, the document doesn't save.

Stab in the dark here (I speak Java a lot more fluently than C#), but would you need a line to the effect of...

document.save(saveFileDialog1.getSavePath())

... after calling the "saveFileDialog1" in order to complete the operation?

 

Whenever I use save dialogs in Java, they only return a path to a file, and don't do any of the saving work themselves, so that's my line of reasoning.

[WelshDdraig]

18 minutes ago, AbydosOne said:

Stab in the dark here (I speak Java a lot more fluently than C#), but would you need a line to the effect of...

document.save(saveFileDialog1.getSavePath())

... after calling the "saveFileDialog1" in order to complete the operation?

 

Whenever I use save dialogs in Java, they only return a path to a file, and don't do any of the saving work themselves, so that's my line of reasoning.

Thanks for the help. 

That didn't solve my issue - however, it made me take a closer look at my code and I can't believe I was so stupid haha.
Turns out - all I did was open the dialog - I didn't have anything coded to save the file. (Time for me to re-read all my C# books...again.

Here's the code I added to fix my issue:

private void btnGenPDF_Click(object sender, EventArgs e)
        {
            if (document.PageCount > 0)
            {
                {
                    SaveFileDialog dialog = new SaveFileDialog();
                    dialog.Title = "Generate PDF";
                    dialog.Filter = "PDF document (*.pdf)|*.pdf";
                    DialogResult result = dialog.ShowDialog();
                    string fileName = dialog.FileName;
                    if (result == DialogResult.OK)
                    {
                        document.Save(fileName);
                    }                   
                }
            }
        }

Thanks again for the suggestion.