C# Unity Help.

[werto165]

I'm trying to access a color variable from another script and use that in a script to assign a sphere which is attached to my finger to see what color it will come out when pinchdrawing(Leap motion). 

coloring = GameObject.Find("Pinch Draw").GetComponent<PinchDraw>().ColorMem;  

this above line of code works however I was wondering why this wouldn't work: 

 

using UnityEngine;
using System.Collections;
using Leap.Unity.DetectionExamples;

public class pin : MonoBehaviour {
    public Renderer rend;
    private PinchDraw _PinchDraw;
    Color coloring; 
    // Use this for initialization
    void Start () {
        
    }
	void Awake()
    {
        


    }
    // Update is called once per frame
    void Update()
    {   
        rend = GetComponent<Renderer>();
        coloring = GameObject.Find("Pinch Draw").GetComponent<PinchDraw>().ColorMem; 
        
        PinchDraw _PinchDraw = GetComponent<PinchDraw>(); //These two lines don't work
        coloring = _PinchDraw.ColorMem;					// above 
        if (_PinchDraw != null)
        {
            Debug.Log("It worked!"); 
            rend.material.color = _PinchDraw.ColorMem;

        }

        rend.material.color = coloring; 




    }
    
}

Other script in question: 

using UnityEngine;
using System.Collections.Generic;
using UnityEngine.UI; 

namespace Leap.Unity.DetectionExamples {

  public class PinchDraw : MonoBehaviour {
    public float colorRed;
    public float colorGreen;
    public float colorBlue;
    public Color ColorMem;
    public Button rButton;

 

Do I have to assign that script to a gameobject? 

[squirrl]

That script is a MonoBehaviour. it only works when attached to a gameObject. You can get rid of the base class of monobehavoir and make it a normal class, but you still need to instantiate it somewhere.

 

You're also defining this twice

PinchDraw _PinchDraw

 In your update you are saying "look on this gameobject for the attached component of type "pinchdraw"" which doesn't exit. 

 

I advise against "getcomponent" inside update or any other loop. it's really performance heavy. do it outside in your initialisation and only call it when necessary.

[squirrl]

The leap script looks like something external though so it's best to assign it to a game object, since that's how it's meant to be used. But still, do the "getcomponent" in init, or even make the instance public and drag it into the script in the inspector, then you don't have to do the work in the code.

[werto165]

8 minutes ago, squirrl said:

That script is a MonoBehaviour. it only works when attached to a gameObject. You can get rid of the base class of monobehavoir and make it a normal class, but you still need to instantiate it somewhere.

 

You're also defining this twice

PinchDraw _PinchDraw

 In your update you are saying "look on this gameobject for the attached component of type "pinchdraw"" which doesn't exit. 

 

I advise against "getcomponent" inside update or any other loop. it's really performance heavy. do it outside in your initialisation and only call it when necessary.

So the 

private PinchDraw _PinchDraw;

I would get rid of? 

 

I think I could easily set it up as another (don't know the name for it) but say: void GetColor(){

code for finding game object and assigning it to that colour variable I have. 

} that code is only run when I press the button on my unity UI.

[werto165]

public PinchDraw _PinchDraw; and then drag the pinch draw into the inspector. Makes sense that works. 

[werto165]

@squirrl 

 

using UnityEngine;
using System.Collections;
using Leap.Unity.DetectionExamples;

public class pin : MonoBehaviour {
    public Renderer rend;
    public PinchDraw _PinchDraw;
    
    Color coloring; 
    // Use this for initialization
    void Start () {
        rend = GetComponent<Renderer>();
    }
	void Awake()
    {
        


    }
    // Update is called once per frame
    void Update()
    {   
        
        
        rend.material.color = coloring; 




    }
   public void GetColor() {
        coloring = _PinchDraw.ColorMem;
    }
    
}

Anyway of improving this? 
          
          

It seems like the best I can do, whenever I press that button that says "Press" at the moment it runs the GetColor() 

[squirrl]

Why not set the colour in GetColour, only when it changes rather than setting it every frame?

public void GetColor() {
    rend.material.color = coloring;
}

 

[werto165]

8 minutes ago, squirrl said:

Why not set the colour in GetColour, only when it changes rather than setting it every frame?

public void GetColor() {
    rend.material.color = coloring;
}

 

Yeah that seems like a good shout. Just a question, those 3 sliders control the RGB elements of the color to do a real time view of the color without affecting performance is there a way to say poll the update to something like 0.1 - 0.2 secs rather than 0.011secs as it currently is(assuming 90FPS). I guess I could tie the script to the sliders too i.e when depressed it will change color. 

[squirrl]

53 minutes ago, werto165 said:

Yeah that seems like a good shout. Just a question, those 3 sliders control the RGB elements of the color to do a real time view of the color without affecting performance is there a way to say poll the update to something like 0.1 - 0.2 secs rather than 0.011secs as it currently is(assuming 90FPS). I guess I could tie the script to the sliders too i.e when depressed it will change color. 

 

 

Yeah, you can poll. create an integer as a private counter, and another one which defines the poll time. In Update add Time.deltaTime to your counter and then check if it's greater than or equal to the poll time. If it is, then reset the counter to 0, and do your action.