I made a program

[xARACHN1D]

My point is above. I made a program. It is quite primitive but if you would like to try it, be my guest, I am still a beginner however. I would love some feedback.

I zipped it up!

 

GuessingGame.zip

[vorticalbox]

please post source code in [ code ] tags. most people (including myself) will be unwilling to download random programs off the internet.

[wasab]

Nah. How do I know your "game" won't destroy my computer?

[dgsddfgdfhgs]

1 hour ago, vorticalbox said:

please post source code in [ code ] tags. most people (including myself) will be unwilling to download random programs off the internet.

import java.util.Scanner;
public class GuessingGame
{public static void main(String [ ] args)
    {
      Scanner in;
      in = new Scanner(System.in);
      char gameWon = 'N';
      int randNum = (int)(Math.random()*99) + 1;
      int counter = 0;
      while(gameWon == 'N')
      {  
      System.out.println("A Random Number Between 1-100 Has been selected, Try and guess!");
      int guess1 = in.nextInt();
      if(guess1 == randNum){
      counter ++;
      gameWon = 'Y';}
      if(guess1 > randNum)
      System.out.println("Number of Guesses:" + counter);
      if(guess1 > randNum)
      counter ++;
      if(guess1 > randNum)
      System.out.println("Your Guess was too High");
     if(guess1 < randNum)
      counter ++;
      if(guess1 < randNum)
      System.out.println("Your Guess was too Low");
      if(guess1 < randNum)
      System.out.println("Number of Guesses:" + counter);
    }
      if(counter >= 1 && counter <= 3)
      System.out.println("Excellent Guessing!");
      if(counter >= 4 && counter <= 6)
      System.out.println("Good Guessing, You have Talent!");
      if(counter >= 7 && counter <= 10)
      System.out.println("Your Guessing Skills are good!");
      if(counter >= 10)
      System.out.println("Keep Practicing");
    
      
        
        
        
        
        
        
        
        
        
    }
}
 

[dgsddfgdfhgs]

I could try out any unknown source, coz this is my office pc lol

[vorticalbox]

9 minutes ago, dgsddfgdfhgs said:

I could try out any unknown source, coz this is my office pc lol

i'm at the office too, we create a financial CRM that handles millions per month and 1000s of customer private information so rather not risk me job lol

p.s you missed the code tags

print("ew java")

[DevBlox]

Okay, a few things for improvement:

• You should improve your formatting. Code has to be easily readable. You can make out the flow of a program by well intended blocks, it's lacking that now.
• Why gameWon is not a bool? You use it as a bool, but it's not a bool.
• Too many if statements. You actually need maybe just three + plus a while loop. Now you've got 11 (and a while loop). Consequently you have 12 control flow cases. For such a simple program that's enormous.

EDIT:

• You manage to use System.out.println 9 times in this, way too much for this.
• Code duplication. Some if statements are exactly the same. In the same block. Execute right after each other.

[vorticalbox]

8 minutes ago, DevBlox said:

You manage to use System.out.println 9 times in this, way too much for this.
 

Any code that is repeated like this is a good indication that you need to refactor it to a function

[xARACHN1D]

3 hours ago, DevBlox said:

Okay, a few things for improvement:

• You should improve your formatting. Code has to be easily readable. You can make out the flow of a program by well intended blocks, it's lacking that now.
• Why gameWon is not a bool? You use it as a bool, but it's not a bool.
• Too many if statements. You actually need maybe just three + plus a while loop. Now you've got 11 (and a while loop). Consequently you have 12 control flow cases. For such a simple program that's enormous.

EDIT:

• You manage to use System.out.println 9 times in this, way too much for this.
• Code duplication. Some if statements are exactly the same. In the same block. Execute right after each other.

Ok Thanks for all the feedback

 

 

AND yes Sorry I realize now that was was dumb of me to do. I should have put my source code.