programming need help with python program

[Celious]

Trying to make a Heads or Tails program in Python, here is what I have right now:
                                                                                                                                                

 

import time
from random import *
def computerChoice(z):
    Z = (randint(0,1))
    if Z == 1:
        print("Heads")
    elif Z == 0:
        print ("Tails")
    return(z)
    

def anwser(x):
    x = (randint(0,1))
    if x == 1:
        print("Heads")
    elif x == 0:
        print ("Tails")
    return (x)

playerChoice = input("Heads or Tails: ").upper()
if playerChoice == 'HEADS' or 'TAILS':
   
print ("You chose:", playerChoice)
    time.sleep(0.1)
    print ("Computer chose:", computerChoice)                   

 The problem is that at the last line instead of printing 'Heads' or 'Tails' it prints this:      <function computerChoice at 0x030DFF18>             

[Fire Yoshi]

You forgot the parentheses. It should be :

print("Computer chose:", computerChoice())

You should also remove x and z from your function definitions as they are not needed (those are parameters, not return variables).

[LtStaffel]

And you should also use code tags

[Celious]

3 minutes ago, LtStaffel said:

And you should also use code tags

You mean hash?

[Fire Yoshi]

Just now, Celious said:

You mean hash?

He means in your post, you can use the " <> " button in the upper bar to insert formatted code like I did.

[Celious]

9 minutes ago, Fire Yoshi said:

You forgot the parentheses. It should be :

print("Computer chose:", computerChoice())

You should also remove x and z from your function definitions as they are not needed (those are parameters, not return variables).

alright i did that this is what i updated the code to be:

 

import time
from random import *
def computerChoice():
    Z = (randint(0,1))
    if Z == 1:
        print("Heads")
    elif Z == 0:
        print ("Tails")
    return(z)
    

def anwser():
    x = (randint(0,1))
    if x == 1:
        print("Heads")
    elif x == 0:
        print ("Tails")
    return (x)
playerChoice = input("Heads or Tails: ").upper()
if playerChoice == 'HEADS' or 'TAILS':
    print ("You chose:", playerChoice)
    time.sleep(0.1)
    print ("Computer chose:", computerChoice())

However it still comes up with an error, which is:

NameError: name 'z' is not defined

[LtStaffel]

Here is a python 2.7 version of your script (because I'm using PyPy which is 2.7 style syntax)

Please mark this post as the answer so the thread is "solved"

 

Spoiler

from random import *

def answer():
    # You don't need elif, it either will be 1 or zero so only make one check and use else
    x = (randint(0, 1))
    if x == 1:
        return "HEADS"
    else:
        return "TAILS"
        # You were returning the parameter given to the function, when the function didn't need a parameter
        # You were also printing the result instead of returning it

playerChoice = str(raw_input("Heads or Tails: ")).upper()
if playerChoice == 'HEADS' or 'TAILS':
    # You didn't indent properly
    print "You chose: " + playerChoice
    # You don't need to wait a split second
    # Also, the computer doesn't get a choice if the player chooses
    # Here we get the result using your function "answer"
    ans = answer()
    print "You chose  ::: " + playerChoice
    print "The answer ::: " + ans
    if playerChoice == ans:
        print "You won!"
    else:
        print "You lost!"
else:
    print "Invalid input!"

 

 

 

[Guest]

7 minutes ago, Celious said:

alright i did that this is what i updated the code to be:

 

import time
from random import *

def computerChoice():
    Z = (randint(0,1))
    if Z == 1:
        print("Heads")
    elif Z == 0:
        print ("Tails")
    return(z)
    

def anwser():
    x = (randint(0,1))
    if x == 1:
        print("Heads")
    elif x == 0:
        print ("Tails")
    return (x)

playerChoice = input("Heads or Tails: ").upper()

if playerChoice == 'HEADS' or 'TAILS':
    print ("You chose:", playerChoice)
    time.sleep(0.1)
    print ("Computer chose:", computerChoice())

However it still comes up with an error, which is:

NameError: name 'z' is not defined

import time
from random import *

def computerChoice():
    if (randint(0,1) == 1):
        return "Heads"
    else:
        return "Tails"

def playerChoice():
    while True:
        playerChoice = input("Heads or Tails: ").upper()
        if playerChoice == 'HEADS' or playerChoice == 'TAILS':
            return playerChoice
        else:
            print("That is not an answer.")
    
playerChoiceAnswer = playerChoice()
print("You chose:", playerChoiceAnswer)
time.sleep(0.1)
print ("Computer chose:", computerChoice())    

 

[LtStaffel]

2 minutes ago, tjcater said:

-snip for space-

 

Beat you by two lines

[Guest]

Just now, LtStaffel said:

Beat you by two lines

Just gotta put it all on one line

[LtStaffel]

Just now, tjcater said:

Just gotta put it all on one line

With python you'll need at list two for any script of value

[Guest]

7 minutes ago, tjcater said:

if playerChoice == 'HEADS' or 'TAILS':

This should be write as:

if playerChoice == 'HEADS' or playerChoice == 'TAILS':

As the argument works like this:

if (playerChoice == 'HEADS') or ('TAILS'):

With the condition 'TAILS', the argument is always satisfied, thus any input works.

[LtStaffel]

3 minutes ago, tjcater said:

This should be write as:

if playerChoice == 'HEADS' or playerChoice == 'TAILS':

As the argument works like this:

if (playerChoice == 'HEADS') or ('TAILS'):

With the condition 'TAILS', the argument is always satisfied, thus any input works.

Another, longer, option might be:

choices = ['HEADS', 'TAILS', 'EXIT']
if playerChoice in choices:
	blah blah blah

which allows for exiting the game

[Guest]

34 minutes ago, Celious said:

 

def computerChoice():
    Z = (randint(0,1))
    if Z == 1:
        print("Heads")
    elif Z == 0:
        print ("Tails")
    return(z)

However it still comes up with an error, which is:

NameError: name 'z' is not defined

Well I guess we didn't answer that question for you , sorry about that, the reason why is that you defined "Z" and not "z". Python is case sensitive.

[Celious]

alright thanks, how do i mark this as solved?

[Guest]

Just now, Celious said:

alright thanks, how do i mark this as solved?

Click on the check mark beside the share button (If you hover over it, it will say marked as solved) on what you think is the answer.

[Celious]

You might of saw me already with an earlier version of this program, I have now finished it but there is one bug.
Everything works fine but the "You won" and "You lost" statements, it seems to be kinda random. But here's the code:
INFORMATION: PYTHON 3.6.2
 

import time
from random import *

def computerChoice():
    Z = (randint(0,1))
    if Z == 1:
        return("HEADS")
    elif Z == 0:
        return ("TAILS")
    
    


def anwser():
    x = (randint(0,1))
    if x == 1:
        return("HEADS")
    elif x == 0:
        return ("TAILS")
    

playerChoice = input("Heads or Tails: ").upper()

if playerChoice == 'HEADS' or playerChoice == 'TAILS':
    print ("You chose:", playerChoice)
    time.sleep(0.2)
    print ("Computer chose:", computerChoice())
    time.sleep(0.2)
    print("The anwser was: ", anwser())
    



if playerChoice == anwser():
    print("you won")
elif computerChoice == anwser():
    print("you lost")

 

[staubgame]

11 minutes ago, Celious said:

You might of saw me already with an earlier version of this program, I have now finished it but there is one bug.
Everything works fine but the "You won" and "You lost" statements, it seems to be kinda random. But here's the code:
INFORMATION: PYTHON 3.6.2
 

import time
from random import *

def computerChoice():
    Z = (randint(0,1))
    if Z == 1:
        return("HEADS")
    elif Z == 0:
        return ("TAILS")
    
    


def anwser():
    x = (randint(0,1))
    if x == 1:
        return("HEADS")
    elif x == 0:
        return ("TAILS")
    

playerChoice = input("Heads or Tails: ").upper()

if playerChoice == 'HEADS' or playerChoice == 'TAILS':
    print ("You chose:", playerChoice)
    time.sleep(0.2)
    print ("Computer chose:", computerChoice())
    time.sleep(0.2)
    print("The anwser was: ", anwser())
    



if playerChoice == anwser():
    print("you won")
elif computerChoice == anwser():
    print("you lost")

 

 

I should know this, but I don't...

 

Now I want to know this... ^^

 

When I run it, the computer can choose the same value as me, not sure if that is intended? ^^

Also, it's either won or nothingat all...  

[WiiManic]

Do you ever store the computer's choice? It looks like you are just calling the function, rather than saving the result.

So when you check who has won the "computerChoice" variable is never set.

 

Looks like you need to store that choice too, should help a bit.

 

Also, since you aren't storing the answer, the answer will change potentially when you are checking it.

[ignaloidas]

 

Todays is you happy day: I fixed it all.

import time
from random import *

def computerChoice():
    Z = (randint(0,1))
    if Z == 1:
        return("HEADS")
    elif Z == 0:
        return ("TAILS")
    
    


def anwser():
    x = (randint(0,1))
    if x == 1:
        return("HEADS")
    elif x == 0:
        return ("TAILS")
a=1
while a
    playerChoice = input("Heads or Tails: ").upper()

    if playerChoice == 'HEADS' or playerChoice == 'TAILS':
        print ("You chose:", playerChoice)
        time.sleep(0.2)
        computerCh=computerChoice()        #change here
        print ("Computer chose:", computerCh)
        time.sleep(0.2)
        anws=anwser()                    #and here
         print("The anwser was: ", anws)
        a=0
    else:
          print("Please write heads or tails:") #never trust user input
    


if playerChoice == anws:
    print("you won")
else: #dont need as it only should be only one
    print("you lost")

 

[staubgame]

8 minutes ago, WiiManic said:

Do you ever store the computer's choice? It looks like you are just calling the function, rather than saving the result.

So when you check who has won the "computerChoice" variable is never set.

 

Looks like you need to store that choice too, should help a bit.

 

Also, since you aren't storing the answer, the answer will change potentially when you are checking it.

 

3 minutes ago, ignaloidas said:

 

Todays is you happy day: I fixed it all.

import time
from random import *

def computerChoice():
    Z = (randint(0,1))
    if Z == 1:
        return("HEADS")
    elif Z == 0:
        return ("TAILS")
    
    


def anwser():
    x = (randint(0,1))
    if x == 1:
        return("HEADS")
    elif x == 0:
        return ("TAILS")
a=1
while a
    playerChoice = input("Heads or Tails: ").upper()

    if playerChoice == 'HEADS' or playerChoice == 'TAILS':
        print ("You chose:", playerChoice)
        time.sleep(0.2)
        computerCh=computerChoice()        #change here
        print ("Computer chose:", computerCh)
        time.sleep(0.2)
        anws=anwser()                    #and here
         print("The anwser was: ", anws)
        a=0
    else:
          print("Please write heads or tails:") #never trust user input
    


if playerChoice == anws:
    print("you won")
else: #dont need as it only should be only one
    print("you lost")

 

Hm was 50% on my way there as well.

I actually figured this with storing the values.

 

Really need to get back to working on my skills...

Just starting with python and programming in general.

 

Though, technically speaking, there's probably a more "clean" way to do it.

 

[divito]

The "anwser" typo is bothering me to no end.

[Celious]

On 26/09/2017 at 10:24 PM, WiiManic said:

Do you ever store the computer's choice? It looks like you are just calling the function, rather than saving the result.

So when you check who has won the "computerChoice" variable is never set.

 

Looks like you need to store that choice too, should help a bit.

 

Also, since you aren't storing the answer, the answer will change potentially when you are checking it.

how do i store it?, btw i updated the code a bit
 

import time
from random import randint


    
    

#Randomiser
def alpha():
    value = (randint(0,1))
    if value == 1:
        return("HEADS")
    elif value == 0:
        return ("TAILS")
  


#asking for input
player1 = input("(Player 1) Heads or Tails?: ").upper()

player2 = input("(Player 2) Heads or Tails?: ").upper()


#printing result
print("The coin is flipping...")

time.sleep(0.3)

print("The coin landed on: ",alpha())
### I need a way to store this value ### 
#So i can use it here vv ## 
if player1 == alpha():
    print("testing")

 

[Celious]

nvm i got it, i assigned a variable to the randomiser then print the variable

[mathijs727]

There is a more elegant way of picking a random answer:

import random

print(random.choice(["heads", "tails"]))