[HELP] C++ while true loop

[rcarlos243]

Spoiler

#include <iomanip>
#include <iostream>
using namespace std;
#include <cmath>

main() {
    
    int usersGuess; //
    
    cout << "I'm thinking of a number between 1-100\n";
    cout << "Guess what it is: ";
    cin >> usersGuess;
    cin.ignore(1000, 10);

    while(true) {

    if( usersGuess == 7) break; // see if the guess is right

    if( usersGuess > 7 );
    cout << "That's too high.\n";
    cout << "Guess what it is: ";
    cin >> usersGuess;
    cin.ignore(1000, 10);
    
    if( usersGuess < 7);
    cout << "That's too low.\n";
    cout << "Guess what it is: ";
    cin.ignore(1000, 10);
    }
    
    
    

    cout << "Jackpot!";
    
    
    
}

 

If I input greater than 7 it should say it "That's too high".

The problem is if I input greater than 7 again it says "That's too low" when it should have been that's too high.

 

Im confused

 

 

[Enderman]

first use elif and else statements instead of just going if if if all the time

[RedWulf]

Quote

#include <iomanip>
#include <iostream>
#include <string>
using namespace std;
#include <cmath>
main() {
    
    int usersGuess; //
    
    cout << "I'm thinking of a number between 1-100\n";
    cout << "Guess what it is: ";
    cin >> usersGuess;
    cin.ignore(1000, 10);
    while(true) {
    if( usersGuess == 7) break; // see if the guess is right
    
    elif( usersGuess > 7 );
    cout << "That's too high.\n";
    cout << "Guess what it is: ";
    cin >> usersGuess;
    cin.ignore(1000, 10);
    
    else;
    cout << "That's too low.\n";
    cout << "Guess what it is: ";
    cin.ignore(1000, 10);
    }

Maybe as @Enderman said, like this

[rcarlos243]

5 minutes ago, RedWulf said:

Maybe as @Enderman said, like this

 

I am using C9.IO as integrated development environment (IDE)

[rcarlos243]

13 minutes ago, Enderman said:

first use elif and else statements instead of just going if if if all the time

that didn't work

[prolemur]

1 minute ago, rcarlos243 said:

that didn't work

*else if

[RedWulf]

Quote

#include <iomanip>
#include <iostream>
#include <string>
using namespace std;
#include <cmath>
main() {
    
    int usersGuess; //
    
    cout << "I'm thinking of a number between 1-100\n";
    cout << "Guess what it is: ";
    cin >> usersGuess;
    cin.ignore(1000, 10);
    while(true) {
    
    if( usersGuess > 7 );
       cout << "That's too high.\n";
       cout << "Guess what it is: ";
       cin >> usersGuess;
       cin.ignore(1000, 10);
    
    else if( usersGuess < 7) 
       cout << "That's too low.\n";
       cout << "Guess what it is: ";
       cin.ignore(1000, 10);
    
    else;
       break;

    }
    

Maybe switch the values around so that break is the last option. 

[rcarlos243]

5 minutes ago, prolemur said:

*else if

 

It is still not happy

[msevilgenius]

This is what your code is doing

( the semicolons after the if expressions mean that they do nothing)

cout << "I'm thinking of a number between 1-100\n";
    cout << "Guess what it is: ";
    cin >> usersGuess;
    cin.ignore(1000, 10);
    while(true) {
    if( usersGuess == 7) { break; } // see if the guess is right
    if( usersGuess > 7 ){
        // do nothing
    }
    cout << "That's too high.\n";
    cout << "Guess what it is: ";
    cin >> usersGuess;
    cin.ignore(1000, 10);
    
    if( usersGuess < 7){
        // do nothing
    }
    cout << "That's too low.\n";
    cout << "Guess what it is: ";
    cin.ignore(1000, 10);
    }

 

You should use braces like this:

cout << "I'm thinking of a number between 1-100\n";
while(true) {
    cout << "Guess what it is: ";
    cin >> usersGuess;
    if( usersGuess > 7 ){
    	cout << "That's too high.\n";
    }else if( usersGuess < 7){
    	cout << "That's too low.\n";
    }else{ // usersGuess == 7
    	break;
    }
}

 

[rcarlos243]

6 minutes ago, RedWulf said:

Maybe switch the values around so that break is the last option. 

I can't do that because the break should be initiated if the correct answer is guess which is 7.

 

The problem is I want to keep looping "That's too high" if the user inputs greater than 7 and skip the "That's too low".

[RedWulf]

Then replace else with else if from the last code revision or @msevilgenius suggestion and include another else with the loop call, I'm not sure if c++ uses it though, I'm a python guy

maybe this is a problem? 

http://www.cplusplus.com/forum/beginner/144641/

[RedWulf]

If nothing else heres a loop from another article that has claimed to work, you'd need to replace the int number from the random pattern to the number you want (7) 

Quote

#include <iostream>
#include <cstdlib>
#include <ctime>

int main(void) {
	srand(time(NULL)); // To not have the same numbers over and over again.
	
	while(true) { // Main loop.
		// Initialize and allocate.
		int number = rand() % 99 + 2; // System number is stored in here.
		int guess; // User guess is stored in here.
		int tries = 0; // Number of tries is stored here.
		char answer; // User answer to question is stored here.
		
		//std::cout << number << "\n"; // Was used for debug...
		
		while(true) { // Get user number loop.
			// Get number.
			std::cout << "Enter a number between 1 and 100 (" << 20 - tries << " tries left): ";
			std::cin >> guess;
			std::cin.ignore();
			
			// Check is tries are taken up.
			if(tries >= 20) {
				break;
			}
			
			// Check number.
			if(guess > number) {
				std::cout << "Too high! Try again.\n";
			} else if(guess < number) {
				std::cout << "Too low! Try again.\n";
			} else {
				break;
			}
			
			// If not number, increment tries.
			tries++;
		}
		
		// Check for tries.
		if(tries >= 20) {
			std::cout << "You ran out of tries!\n\n";
		} else {
			// Or, user won.
			std::cout<<"Congratulations!! " << std::endl;
			std::cout<<"You got the right number in " << tries << " tries!\n";
		}
		
		while(true) { // Loop to ask user is he/she would like to play again.
			// Get user response.
			std::cout << "Would you like to play again (Y/N)? ";
			std::cin >> answer;
			std::cin.ignore();
			
			// Check if proper response.
			if(answer == 'n' || answer == 'N' || answer == 'y' || answer == 'Y') {
				break;
			} else {
				std::cout << "Please enter \'Y\' or \'N\'...\n";
			}
		}
		
		// Check user's input and run again or exit;
		if(answer == 'n' || answer == 'N') {
			std::cout << "Thank you for playing!";
			break;
		} else {
			std::cout << "\n\n\n";
		}
	}
	
	// Safely exit.
	std::cout << "\n\nEnter anything to exit. . . ";
	std::cin.ignore();
	return 0;
}

 

[Nineshadow]

Your code has quite a few very obvious syntax issues.

Anyway :

#include <iostream>
using namespace std;

main()
{

    int usersGuess;
    cout << "I'm thinking of a number between 1-100\n";
    cout << "Guess what it is: ";
    cin >> usersGuess;
    while(true)
    {
        if( usersGuess == 7) break;
        if( usersGuess > 7 )
        {
            cout << "That's too high.\n";
            cout << "Guess what it is: ";
            cin >> usersGuess;
        }

        if( usersGuess < 7)
        {
            cout << "That's too low.\n";
            cout << "Guess what it is: ";
            cin >> usersGuess;
        }
    }
    cout << "Jackpot!";



}

This should fix it.

 

Learn the proper if statement syntax in C :

if(<condition>)
{
<instructions>
}

 

[rcarlos243]

3 minutes ago, Nineshadow said:

Your code has quite a few very obvious syntax issues.

Anyway :

#include <iostream>
using namespace std;

main()
{

    int usersGuess;
    cout << "I'm thinking of a number between 1-100\n";
    cout << "Guess what it is: ";
    cin >> usersGuess;
    while(true)
    {
        if( usersGuess == 7) break;
        if( usersGuess > 7 )
        {
            cout << "That's too high.\n";
            cout << "Guess what it is: ";
            cin >> usersGuess;
        }

        if( usersGuess < 7)
        {
            cout << "That's too low.\n";
            cout << "Guess what it is: ";
            cin >> usersGuess;
        }
    }
    cout << "Jackpot!";



}

This should fix it.

Holy crap it did fixed it

 

BTW why did you not use cin.ignore(1000, 10)?

my Prof always says to include it when making a prompt.

[Nineshadow]

Just now, rcarlos243 said:

Holy crap it did fixed it

 

BTW why did you not use cin.ignore(1000, 10)?

my Prof always says to include it when making a prompt.

It won't really make much of a difference here honestly.

Cin leaves the newline character in the stream. Adding cin.ignore() to the next line clears/ignores the newline from the stream. This is used mainly with combinations of cin and getline.