PHP help please

unijab · November 5, 2015

I am trying to figure out how to write this function so I can pass a variable to it from a foreach loop and return two variables that I can echo.

I know the first function ( get_uniq_tcp_ports ) works, i tested it before I started working on the count_tcp function.

function count_tcp($port) {        global $db;        $query = "SELECT dpt,count(dpt) FROM logs WHERE proto = 'tcp' and dpt = :port";        $statement = $db->prepare($query);        $statement->execute();        $statement->bindValue(":port", $port);        $array = $statement->fetch();        $statement->closeCursor();        return $test = array($dpt,$count);}<html><h2>TCP</h2>        <?php $ports = get_uniq_tcp_ports(); foreach ($ports as $port) : ?>                <?php count_tcp($port);                 echo $test[$dpt]; echo $test[$count]; ?></br>        <?php endforeach; ?></html>

minibois · November 5, 2015

Maybe @Limecat86 can help.

Wander Away · November 5, 2015

@Judahnator Heres some1 else as well.

minibois · November 5, 2015

-snip-

What is not working? And shouldn't the html be in a <body>?

If you are gonna answer me, please do quote me. Going to sleep now, but will try to help you tomorrow if your issue is not resolved.

unijab · November 5, 2015

What is not working? And shouldn't the html be in a <body>?

If you are gonna answer me, please do quote me. Going to sleep now, but will try to help you tomorrow if your issue is not resolved.

I have no output currently - I dont even see my html tags, so I suspect the function is wrong.

Blade of Grass · November 5, 2015


<?php

function count_tcp($port) {

        global $db;

        $query = "SELECT dpt,count(dpt) FROM logs WHERE proto = 'tcp' and dpt = :port";

        $query_params = array(':port' => , $port);

 

        $statement = $db->prepare($query);

        $statement->execute($query_params);

 

        $row = $statement->fetch();

        return $row;

}

?>

 

<html>

    <body>

        <h2>TCP</h2>

        <?php 

 

        $ports = get_uniq_tcp_ports(); 

        foreach ($ports as $port) {

             $row = count_tcp($port);

             echo $row['dpt'] . " | " . $row['count(dpt)'];

        } 

        ?>

    </body>

</html>

Brenz · November 5, 2015

Ok, obviously I can't execute your code without the DB and the rest of the code but there are a few things I can see that don't look correct.

1.

        $array = $statement->fetch();        $statement->closeCursor();        return $test = array($dpt,$count);

Here you are fetching the data from the results into $array which I assume will look something like:

array(    'dpt' => 'value'    'count' => 1,)

Yet further down you never use $array and instead try and use $dpt and $count which are unset variables. Try just returning $array instead.

2.

<?php $ports = get_uniq_tcp_ports(); foreach ($ports as $port) : ?>

Please put this on two lines. There should never be code on a line after a ;

3.

<?php count_tcp($port);

This will return data from your function (when written correctly) but without stating where the returned data will be stored it will be lost. You need something like:

<?php $tcpResult = count_tcp($port);

4.

echo $test[$dpt]; echo $test[$count]; ?></br>

Again on this line $test, $dpt and $count are undefined. Using the changes in point 3 you should be able to access your data like:

$tcpResult['dpt']

Again you shouldn't have code after a ; but we can concatenate the string using periods so this line should look something like:

echo $tcpResult['dpt']." ".$tcpResult['count']; ?></br>

minibois · November 5, 2015

I have no output currently - I dont even see my html tags, so I suspect the function is wrong.

-snip-

If this resolves it, I saw the error

Unijab, you forgot to put <body> tags inside the html part of the code.

Blade of Grass · November 5, 2015

If this resolves it, I saw the error

Unijab, you forgot to put <body> tags inside the html part of the code.

Nah, that's not it.

Refer to post above for a good explanation.

unijab · November 5, 2015

<?phpfunction count_tcp($port) {        global $db;        $query = "SELECT dpt,count(dpt) FROM logs WHERE proto = 'tcp' and dpt = :port";        $query_params = array(':port' => , $port);         $statement = $db->prepare($query);        $statement->execute($query_params);         $row = $statement->fetch();        return $row;}?> <html>    <body>        <h2>TCP</h2>        <?php          $ports = get_uniq_tcp_ports();         foreach ($ports as $port) {             $row = count_tcp($port);             echo $row['dpt'] . " | " . $row['count(dpt)'];        }         ?>    </body></html>

I have a blank page after making these changes.

Blade of Grass · November 5, 2015

I have a blank page after making these changes.

Oops, missed semi colon and additional comma (line 23 for semi-colon and 5 for comma).

<?phpfunction count_tcp($port) {    global $db;    $query = "SELECT dpt,count(dpt) FROM logs WHERE proto = 'tcp' and dpt = :port";    $query_params = array(':port' => $port);    $statement = $db->prepare($query);    $statement->execute($query_params);    $row = $statement->fetch();    return $row;}?><html>    <body>        <h2>TCP</h2>        <?php         $ports = get_uniq_tcp_ports();         foreach ($ports as $port) {             $row = count_tcp($port);             echo $row['dpt'] . " | " . $row['count(dpt)'];        }         ?>    </body></html>

EDIT: Also, try looking through your error.log file to help you troubleshoot the issue.

Brenz · November 5, 2015

If this resolves it, I saw the error

Unijab, you forgot to put <body> tags inside the html part of the code.

While correct use of HTML tags should always be done, most modern browsers will automatically add them in where required so missing them out will rarely break a webpage any more

unijab · November 5, 2015

Oops, missed semi colon and additional comma (line 23 for semi-colon and 5 for comma).

<?phpfunction count_tcp($port) {    global $db;    $query = "SELECT dpt,count(dpt) FROM logs WHERE proto = 'tcp' and dpt = :port";    $query_params = array(':port' => $port);    $statement = $db->prepare($query);    $statement->execute($query_params);    $row = $statement->fetch();    return $row;}?><html>    <body>        <h2>TCP</h2>        <?php         $ports = get_uniq_tcp_ports();         foreach ($ports as $port) {             $row = count_tcp($port);             echo $row['dpt'] . " | " . $row['count(dpt)'];        }         ?>    </body></html>

These changes resulted in many lines of the following.

| 0

unijab · November 5, 2015

Ok, obviously I can't execute your code without the DB and the rest of the code but there are a few things I can see that don't look correct.

1.
        $array = $statement->fetch();        $statement->closeCursor();        return $test = array($dpt,$count);
Here you are fetching the data from the results into $array which I assume will look something like:
array(    'dpt' => 'value'    'count' => 1,)
Yet further down you never use $array and instead try and use $dpt and $count which are unset variables. Try just returning $array instead.

2.
<?php $ports = get_uniq_tcp_ports(); foreach ($ports as $port) : ?>
Please put this on two lines. There should never be code on a line after a ;

3.
<?php count_tcp($port);
This will return data from your function (when written correctly) but without stating where the returned data will be stored it will be lost. You need something like:
<?php $tcpResult = count_tcp($port);
4.
echo $test[$dpt]; echo $test[$count]; ?></br>
Again on this line $test, $dpt and $count are undefined. Using the changes in point 3 you should be able to access your data like:
$tcpResult['dpt']
Again you shouldn't have code after a ; but we can concatenate the string using periods so this line should look something like:
echo $tcpResult['dpt']." ".$tcpResult['count']; ?></br>

1

The output from the sql query ran from phpmyadmin gives....

2

I am entirely a noob at php... I dont really understand how to work with arrays and returns and functions.

3-5

I'll give those changes a try and return

Brenz · November 5, 2015

1

The output from the sql query ran from phpmyadmin gives....

In that case change this line:

$query = "SELECT dpt,count(dpt) FROM logs WHERE proto = 'tcp' and dpt = :port";

to:

$query = "SELECT dpt,count(dpt) AS count FROM logs WHERE proto = 'tcp' and dpt = :port";

This will change the 'count(dpt)' column to 'count' which is a bit easier to read

unijab · November 5, 2015

In that case change this line:
$query = "SELECT dpt,count(dpt) FROM logs WHERE proto = 'tcp' and dpt = :port";
to:
$query = "SELECT dpt,count(dpt) AS count FROM logs WHERE proto = 'tcp' and dpt = :port";
This will change the 'count(dpt)' column to 'count' which is a bit easier to read

How do I return those two columns so I can echo them?

Blade of Grass · November 5, 2015

What does get_uniq_tcp_ports() return?

Brenz · November 5, 2015

How do I return those two columns so I can echo them?

This line here fetches the result:

$array = $statement->fetch();

If you want to see the result after this line you could do:

var_dump($array);

This will show you what is stored in $array. It should look similar to:

array(    'dpt' => 'value'    'count' => 1,)

unijab · November 5, 2015

This line here fetches the result:
$array = $statement->fetch();
If you want to see the result after this line you could do:
var_dump($array);
This will show you what is stored in $array. It should look similar to:
array(    'dpt' => 'value'    'count' => 1,)

Currently getting this repeated

on var_dump

array(2) { ["dpt"]=> NULL ["count"]=> NULL }

unijab · November 5, 2015

What does get_uniq_tcp_ports() return?

With my php as the following I get this output which is a list of the unique integers in that column of the sql table.

<?php $ports = get_uniq_tcp_ports();                foreach ($ports as $port) {                        echo $port[dpt];                        echo '</br>';                } ?>

Brenz · November 5, 2015

Ok, so I'm guessing your $ports array has 3 results in it. The count_tcp seems to be returning the array but there are no results.

Can you post your code as you have it now just to check please

Blade of Grass · November 5, 2015

Ok, so I'm guessing your $ports array has 3 results in it. The count_tcp seems to be returning the array but there are no results.

Can you post your code as you have it now just to check please

Its his for each loop causing problems.

Your for each loop iterates through an array, but when you call the function to count the port you give it an array, not a number.

unijab · November 5, 2015

This looks promising.....

I actually got var_dump to display something other than false or NULL

Code:

// Get all distinct tcp portsfunction get_uniq_tcp_ports() {      global $db;      $query = "SELECT distinct(dpt) FROM logs where proto = 'tcp' ";      $statement = $db->prepare($query);      $statement->execute();      $ports = $statement->fetchAll();      $statement->closeCursor();      return $ports;}// Count the portsfunction count_tcp($port) {        global $db;        $query = "SELECT dpt,count(dpt) as count FROM logs WHERE proto = 'tcp' and dpt = :port";        $statement = $db->prepare($query);        $statement->bindValue(":port", $port);        $statement->execute();        $row = $statement->fetch();        $statement->closeCursor();        return $row;}<?php $ports = get_uniq_tcp_ports();                foreach ($ports as $port) {                        $tcpResult = count_tcp($port[0]);                        var_dump($tcpResult);                 } ?>

Dump:

Brenz · November 5, 2015

Ok so now replace the var_dump with:

echo $tcpResult['dpt']." ".$tcpResult['count']; ?><br />

unijab · November 5, 2015

Thanks for the help guys! (or gals)

Sign In

PHP help please

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites

Link to post

Share on other sites

Link to comment

Share on other sites