Console.ReadLine not getting correct input (C#)

[RileyTheFox]

Hey. I'm making a console application and I need to get user input to do things with the program.

 

However, upon testing, I need to enter the correct 'command' 2 or 3 times for the code to register that I've typed what it's looking for. I type it the exact same way every time but it will only execute code on the 2nd or 3rd attempt.

 

if (Console.ReadLine() == "hello") Console.WriteLine("Hello.");

 

As you can see, I had to type 'hello' twice for the program to respond with 'Hello.'

 

What am I doing wrong? 

[Chris_R.]

I just tried this myself, it works for me first readline.

 

I put it into a for loop and it also worked...do you have any code surrounding what you posted??

 

[RileyTheFox]

2 minutes ago, Chris_R. said:

I just tried this myself, it works for me first readline.

 

I put it into a for loop and it also worked...do you have any code surrounding what you posted??

 

This is the entire thing. Mine is also in a for loop 

for(; ; )
            {
                if (Console.ReadLine() == "reload")
                {
                    try
                    {
                        Bot.users.Clear();
                        Utils.cooldowns.Clear();
                        Utils.disabledMods.Clear();
                        Prices.prices.Clear();

                        Utils.GetUsersFile(out Bot.users);
                        Utils.GetCooldowns();
                        Utils.GetDisabledMods();
                        Prices.GetAllPrices();

                        Console.WriteLine("Reloaded!");
                    }
                    catch (Exception)
                    {
                        Console.WriteLine("Error while trying to reload. Please restart the program");
                    }
                }
                if (Console.ReadLine() == "hello") Console.WriteLine("Hello.");

 

[Bartholomew]

12 minutes ago, EvilCat70 said:

This is the entire thing. Mine is also in a for loop 

for(; ; )
            {
                if (Console.ReadLine() == "reload")
                {
                    try
                    {
                        Bot.users.Clear();
                        Utils.cooldowns.Clear();
                        Utils.disabledMods.Clear();
                        Prices.prices.Clear();

                        Utils.GetUsersFile(out Bot.users);
                        Utils.GetCooldowns();
                        Utils.GetDisabledMods();
                        Prices.GetAllPrices();

                        Console.WriteLine("Reloaded!");
                    }
                    catch (Exception)
                    {
                        Console.WriteLine("Error while trying to reload. Please restart the program");
                    }
                }
                if (Console.ReadLine() == "hello") Console.WriteLine("Hello.");

 

Store the result of readline in a variable.

 

The first if is where your first hello is being ignored due to testing against reload.

 

Readline once, compare result multiple. Now you ask for a new inout line for each comparison, so on each attempt only one word can work (compare equal).

[RileyTheFox]

3 minutes ago, Bartholomew said:

Store the result of readline in a variable.

 

The first if is where your first hello is being ignored due to testing against reload.

 

Readline once, compare result multiple. Now you ask for a new inout line for each comparison, so on each attempt only one word can work (compare equal).

Thank you!

[straight_stewie]

As an aside, while

for ( ; ; )
  // some stuff

works, the following is highly preferable:

while (True)
  // do stuff

Because the for loop method might indicate a mistake where the author meant to go back and write the condition, but forgot to do so. In contrast, the while loop method explicitly states that the author meant the loop to be infinite.

[reniat]

10 minutes ago, straight_stewie said:

In contrast, the while loop method explicitly states that the author meant the loop to be infinite.

+1 for writing explicit self documenting code