What do you guys think of code?

[babadoctor]

what could be changed

i know this is a very limited picture and code, but...

i want your opinion with code given

is it horrid?

[vanished]

It looks good, and I mean that in the most literal sense

 

Not sure what it's supposed to do or even the language, so can't comment on functionality, but it looks good, and it also looks like it should work, I think

 

You wouldn't believe the number of people who have absolutely no idea how to just format their code, in terms of indentation, etc. never mind the actual writing...

[manikyath]

does your language of choice support switch/case statements? thats the "decent" way to handle this.

 

in case of java: https://docs.oracle.com/javase/tutorial/java/nutsandbolts/switch.html

[babadoctor]

It doesnt, thanks for pointing that out!

[Blade of Grass]

You could replace the while loop with a for loop, or move the incrementation of ID into the assignment statement.

Other than that (and the mention of switch statements above), it looks good. I mean, I guess you could make it more object oriented, but whether or not that's worth it is up to you.

[babadoctor]

You could replace the while loop with a for loop, or move the incrementation of ID into the assignment statement.

Other than that (and the mention of switch statements above), it looks good. I mean, I guess you could make it more object oriented, but whether or not that's worth it is up to you.

right now im not focused on making it air tight...

its not like the users ever gonna go through and criticize my code... right?

also since your here WHAT HAVE YOU DONE WITH THE WHOS VIEWING MY TOPIC BAR!!!!!!

[Blade of Grass]

right now im not focused on making it air tight...

its not like the users ever gonna go through and criticize my code... right?

also since your here WHAT HAVE YOU DONE WITH THE WHOS VIEWING MY TOPIC BAR!!!!!!

We're just testing some stuff out.

[Nuluvius]

First of all use code tags not images. Secondly get rid of all of those magic numbers. They should be behind clearly defined constants... if they even really need to exist at all. Often needing so many as is the case here is a bad code smell which is indicative of a problem with the design.

[prolemur]

right now im not focused on making it air tight...

its not like the users ever gonna go through and criticize my code... right?

Well if this is javascript, the users would be able to see it I think. But who does that...

[Nuluvius]

Well if this is javascript, the users would be able to see it I think. But who does that...

I suspect UnityScript personally

[DavidTheWin]

You should define schoolwear as an enum so you can say 

switch schoolwear{  case Uniform: stuff  case Gym: stuff}

Makes it more readable.

 

I'd also pass all the assignments you're making to a function that takes 3 arguments looking like

function(arg1, arg2, arg3){  MyRenderer.materials[0].mainTexture = arg1;  MyRenderer.materials[1].mainTexture = arg2;  MyRenderer.materials[2].mainTexture = arg3;}

Then you just call that function instead of writing it out 3+ times.

[LukeTim]

You should define schoolwear as an enum so you can say 

switch schoolwear{  case Uniform: stuff  case Gym: stuff}

Makes it more readable.

 

I'd also pass all the assignments you're making to a function that takes 3 arguments looking like

function(arg1, arg2, arg3){  MyRenderer.materials[0].mainTexture = arg1;  MyRenderer.materials[1].mainTexture = arg2;  MyRenderer.materials[2].mainTexture = arg3;}

Then you just call that function instead of writing it out 3+ times.

This is good advice.

I don't know if ECMAScript supports enums, but a (still better than the current solution) alternative if it doesn't is to just use named constants.

 

i.e.

var NUDE = 0;var UNIFORM = 1;var SWIMSUIT = 2;var GYM = 3;...if(schoolwear == NUDE){    Nude();}...

[babadoctor]

First of all use code tags not images. Secondly get rid of all of those magic numbers. They should be behind clearly defined constants... if they even really need to exist at all. Often needing so many as is the case here is a bad code smell which is indicative of a problem with the design.

oh shit dude

so if i use 20 tags instead of one to define them all, will the code be bad?

because i just do anything that works...

[Nuluvius]

oh shit dude

so if i use 20 tags instead of one to define them all, will the code be bad?

because i just do anything that works...

 

Judging by the line numbers present in that picture I don't think that at this point you should worry too much. Such is the process of learning...

 

Generally though you should try to understand and learn good software engineering and design principles as soon as possible. It's not all about hammering out line after line of code and crunching that next problem as fast a possible. These principles are arguably far more important and valuable.

• Single responsibility, Open-closed, Liskov substitution, Interface segregation and Dependency inversion (SOLID).
• Atomicity, Consistency, Isolation, Durability (ACID)
• Dependency Injection (DI)
• Inversion of Control (IoC)
• Design Patterns
• Test Driven Development (TDD)
• Behaviour Driven Development (BDD)
• Keep it Simple, Stupid (KISS)

Be mindful of Code Smells, Antipatterns and increasing Cyclomatic complexity i.e. lots of branching logic such as those if elses... get rid of them and employ a design pattern.