code Need help setting up Java comparison

[SavageNeo]

 

Hey! I just started coding and need a bit of help. I need to make a program that reports the course grade according to the given table:  

 

So let me clear some things up.

luku = number

arvosana =grade

mahdotonta = impossible

hylätty = failed

uskomatonta = incredible

anna pisteet = give points

 

But everytime i try to run this program, the program doesnt print anything it is just blank: 

 

so first i made the program to say: give pints between 0-100

then i made the program say different things depending of the points i give. but when i give anything under 0 it will work but otherwise it wont. I need little bit help.

[Mateyyy]

I've not personally worked with Java so for all I know I could be wrong, but isn't "luku == 0-49" incorrect in this context? 

For example if you change "if (luku == 0-49)" to "if (luku >= 0 && luku <= 49)", does it work as intended? 

[BobVonBob]

Your problem is you aren't comparing to the correct things, if I were to guess I'd say this would work correctly for numbers under 0 and over 100, but fails for all the others.

 

The code you have written is being interpreted as such:

else if (luku == (50 - 59)) { ...

Currently you are testing if luku is equal to the beginning of the range minus the end of the range. In other words, they're all testing whether luku is equal to -9 (other than the first one, which is looking for -49).

 

Instead, you need to test if luku is greater than or equal to the lowest number in the range, and less than or equal to the highest number.

[SavageNeo]

9 minutes ago, Mateyyy said:

I've not personally worked with Java so for all I know I could be wrong, but isn't "luku == 0-49" incorrect in this context? 

For example if you change "if (luku == 0-49)" to "if (luku >= 0 && luku <= 49)", does anything change? 

thank you! it solved it.

[Eigenvektor]

You could simplify the comparison a bit by filtering out lower numbers early on.

if (luku < 0) {
   … Arvosana: mahdotonta!

} else if (luku <= 49) {
   … Arvosana: hylätty

} else if (luku <= 59) {
   … Arvosana: 1

} else if (…) {
   …

} else {
   … Arvosana: uskomatonta!

}

This way you only need to compare to a single number each time and the final else will take care of the highest numbers. Should make things a bit easier to read.