not sure why my python 3 code isnt working

[edwardsdean]

as in the title im not sure why this isnt selecting the menu_input properly, any help would be great

 

def instructions():    print("Instructions: It's golf on your console.")    print("For each shot, you may use a driver, iron, or a putter - each shot will vary in distance.")    print("The average distance each club can hit is: Driver = 100m, Iron = 30m, Putter = 10m")    main()def play():    print("play def)")def quit():    print("quit def)")def main():    print()    print("Golf!")    print("(I)nstructions")    print("(P)lay round")    print("(Q)uit")    menu_input = str(input(">>> "))    while menu_input != "i" or menu_input != "I" or menu_input != "p" or menu_input != "P" or menu_input != "q" or menu_input != "Q":        print("Invalid menu choice.")        menu_input = input(">>> ")    if menu_input == "i" or "I":        instructions()    if menu_input == "p" or "P":        play()    if menu_input == "q" or "Q":        quit()print("Let's play golf, CP1200 style!")print("Written by Dean Edwards, June 2014")main()

[Ivyk]

I suggest you also post this on stack overflow.

[edwardsdean]

thank you i will

[CornOnJacob]

Are you getting errors or is it just not working right?

I'm not entirely sure, but if I had to guess, it would be that something like

 if menu_input == "i" or "I":        instructions()

should be

 if menu_input == "i" or menu_input == "I":        instructions()

.

 

Also, use the .lower() or .upper() methods of the string (in this case menu_input) so you don't need to check lower and uppercase every time, just one or the other:

while menu_input.lower() != "i" or menu_input != "p" or menu_input != "q":        print("Invalid menu choice.")

Following the logic from the answer to this post, your code could also be:

while !(menu_input.lower() in ("i", "p", "q"): //not guaranteed to work        print("Invalid menu choice.")

P.S. Your code tags seem to be broken, try editing your post.

[edwardsdean]

i fixed that but the error is in the while loop

 

Let's play golf, CP1200 style!Written by Dean Edwards, June 2014Golf!(I)nstructions(P)lay round(Q)uit>>> kInvalid menu choice.>>> iInvalid menu choice.>>>

[CornOnJacob]

i fixed that but the error is in the while loop

-snip-

The way you have it now, i.e.

while menu_input != "i" or menu_input != "I" or menu_input != "p" or menu_input != "P" or menu_input != "q" or menu_input != "Q":

at least one of those conditions will fail, because menu_input can't equal "i" and "p" at the same time. While menu_input does not equal "i" or it does not equal "p", it will display "invalid menu choice." You made a Catch-22 conditional.

[edwardsdean]

ok i seem to have fixed it for now, untill i break it again

[CornOnJacob]

ok i seem to have fixed it for now, untill i break it again

Good luck

 

In the future, quote posts or use @username to notify people in the thread who didn't follow/subscribe (I only knew you replied because I manually checked the thread).

Also, hit "Mark Solved/Answered" if you are all set.

[edwardsdean]

Good luck

 

In the future, quote posts or use @username to notify people in the thread who didn't follow/subscribe (I only knew you replied because I manually checked the thread).

Also, hit "Mark Solved/Answered" if you are all set.

my bad tirst time posting in forums thanks for telling me tho