Check rectangle overlap given bottom left corner, width, and height

[Zalosath]

Hi,

Can't figure this out for the life of me, everything on StackOverflow and what ChatGPT is trying to tell me doesn't work, always fails one of the conditions and I cannot work out what I'm doing wrong.

 

According to the following:

    public int X1 { get { return x; } }
    public int X2 { get { return x + width; } }
    public int Y1 { get { return y; } }
    public int Y2 { get { return y + height; } }
    
    public bool Overlaps(Room secondRoom)
    {
        if (X2 < secondRoom.X1 || secondRoom.X2 < X1 || Y2 < secondRoom.Y1 || secondRoom.Y2 < Y1)
        {
            return true;
        }
        return false;
    }

These rectangles overlap:

 

And I can assure you, they do not!

 

Debug output:

Blue Rect
X1 Y1    X2  Y2
8, 18 -> 16, 28

Pink Rect
X1 Y1    X2  Y2
7, 6  -> 19, 13

 

Any help greatly appreciated; I feel that this should be simpler than it is being. 

[Zalosath]

Ugh, solved. 
 

    public bool Overlaps(Room secondRoom)
    {
        bool condition1 = X2 - 1 > secondRoom.X1;
        bool condition2 = X1 < secondRoom.X2 - 1;
        bool condition3 = Y2 - 1 > secondRoom.Y1;
        bool condition4 = Y1 < secondRoom.Y2 - 1;

        return condition1 && condition2 && condition3 && condition4;
    }

 

[Sauron]

20 minutes ago, Zalosath said:

what ChatGPT is trying to tell me doesn't work

chatgpt doesn't know what it's talking about, it's a coin toss whether anything it gives you is going to work.

 

It seems to me you have your if statement the wrong way around.

if (X2 < secondRoom.X1 || secondRoom.X2 < X1 || Y2 < secondRoom.Y1 || secondRoom.Y2 < Y1)
{
	return false; //<-- RETURN FALSE HERE
}
return true; //<-- RETURN TRUE HERE