How did I do in my Stopwatch Program? Visual Basic

[pspfreak]

I decided I wanted to make a stopwatch, and a basic one in VB. Here is what the program looks like:

 

Public Class Form1    Dim Seconds As Integer    Dim sraw As Decimal    Dim mraw As Decimal    Dim hraw As Decimal    Dim sround As String    Dim mround As String    Dim hround As String    Private Sub Button1_Click(sender As Object, e As EventArgs) Handles Button1.Click        Timer1.Enabled = True    End Sub    Private Sub Button3_Click(sender As Object, e As EventArgs)        Timer1.Enabled = True    End Sub    Private Sub Button2_Click(sender As Object, e As EventArgs) Handles Button2.Click        Timer1.Enabled = False    End Sub    Private Sub Button4_Click(sender As Object, e As EventArgs)        Timer1.Enabled = False    End Sub    Private Sub Timer1_Tick(sender As Object, e As EventArgs) Handles Timer1.Tick        Seconds = Seconds + 1            ' Second Determine        sraw = Seconds - 60 * Math.Floor(mraw)            mraw = Seconds / 60        hraw = Seconds / 3600        If sraw = 60 Then            sround = "00"        Else            If sround < 9 Then                sround = "0" & sraw            Else                sround = sraw            End If        End If        If mraw = 60 Then            mround = "00"        Else            If mround < 9 Then                mround = "0" & Math.Floor(mraw) - 60 * Math.Floor(hraw)            Else                mround = Math.Floor(mraw) - 60 * Math.Floor(hraw)            End If        End If        If hraw = 60 Then            hround = "00"        Else            If hround < 9 Then                hround = "0" & Math.Floor(hraw)            Else                hround = Math.Floor(hraw)            End If        End If        Label1.Text = hround & ":" & mround & ":" & sround    End Sub    Private Sub Button5_Click(sender As Object, e As EventArgs) Handles Button5.Click        Seconds = 0        Label1.Text = "00:00:00"    End SubEnd Class

Outside of this there is a timer running at an interval of 1000 ms. How good did I do? What ways could I improve on it?

[xox]

I guess you could add functionality like a timer and the ability to stay on top of windows when it's not in focus.

[flibberdipper]

You should make the reset button bigger. Looks goofy.

[Ciccioo]

another way of dealing with the leading zeroes without doing all those if-elses is to use the ToString method of the Integer type with the appropriate parameter

hrow.ToString("D2");

returns the decimal (D) representation of hrow, with at least 2 digits

 

and in regards of how to deal with time, some different maths could make it easier as well

Dim sec As IntegerDim min  As IntegerDim hours As IntegerDim result As Stringsec = Seconds Mod 60min = (Seconds \ 60 ) Mod 60hours = Seconds \ 3600result = sec.ToString("D2") & " : " & min.ToString("D2") & " : " & hours.ToString("D2)

(hopefully this works)

 

just keep in mind that thinking about the code immediately could lead you to do "bad" code

if you plan it taking some more time, you could find simpler/more efficient/more elegant ways of doing the same thing

[pspfreak]

another way of dealing with the leading zeroes without doing all those if-elses is to use the ToString method of the Integer type with the appropriate parameter

hrow.ToString("D2");

returns the decimal (D) representation of hrow, with at least 2 digits

 

and in regards of how to deal with time, some different maths could make it easier as well

Dim sec As IntegerDim min  As IntegerDim hours As IntegerDim result As Stringsec = Seconds Mod 60min = (Seconds \ 60 ) Mod 60hours = Seconds \ 3600result = sec.ToString("D2") & " : " & min.ToString("D2") & " : " & hours.ToString("D2)

(hopefully this works)

 

just keep in mind that thinking about the code immediately could lead you to do "bad" code

if you plan it taking some more time, you could find simpler/more efficient/more elegant ways of doing the same thing

 

Damn... I made it so much more complex than it needed to be.

My code is now this:

 

Public Class Form1    Dim Seconds As Integer    Dim sec As Integer    Dim min As Integer    Dim hours As Integer    Dim result As String    Private Sub Button1_Click(sender As Object, e As EventArgs) Handles Button1.Click        Timer1.Enabled = True    End Sub    Private Sub Button3_Click(sender As Object, e As EventArgs)        Timer1.Enabled = True    End Sub    Private Sub Button2_Click(sender As Object, e As EventArgs) Handles Button2.Click        Timer1.Enabled = False    End Sub    Private Sub Button4_Click(sender As Object, e As EventArgs)        Timer1.Enabled = False    End Sub    Private Sub Timer1_Tick(sender As Object, e As EventArgs) Handles Timer1.Tick        Seconds = Seconds + 1        sec = Seconds Mod 60        min = (Seconds \ 60) Mod 60        hours = Seconds \ 3600        result = hours.ToString("D2") & ":" & min.ToString("D2") & ":" & sec.ToString("D2")        Label1.Text = result    End Sub    Private Sub Button5_Click(sender As Object, e As EventArgs) Handles Button5.Click        Seconds = 0        Label1.Text = "00:00:00"    End SubEnd Class

For now the program still looks the same as above.

[pspfreak]

Made some more progress.

And the code

Public Class Form1    Dim Seconds As Integer    Dim sec As Integer    Dim min As Integer    Dim hours As Integer    Dim result As String    Private Sub Button1_Click(sender As Object, e As EventArgs) Handles Button1.Click        If Timer1.Enabled = True Then            Button1.Text = "Start"            Timer1.Enabled = False        Else            Button1.Text = "Stop"            Timer1.Enabled = True        End If    End Sub    Private Sub Button3_Click(sender As Object, e As EventArgs)         End Sub    Private Sub Button4_Click(sender As Object, e As EventArgs)        Timer1.Enabled = False    End Sub    Private Sub Timer1_Tick(sender As Object, e As EventArgs) Handles Timer1.Tick        Seconds = Seconds + 1        sec = Seconds Mod 60        min = (Seconds \ 60) Mod 60        hours = Seconds \ 3600        result = hours.ToString("D2") & ":" & min.ToString("D2") & ":" & sec.ToString("D2")        Label1.Text = result    End Sub    Private Sub Button5_Click(sender As Object, e As EventArgs) Handles Button5.Click        Seconds = 0        Label1.Text = "00:00:00"    End Sub    Private Sub Form1_Load(sender As Object, e As EventArgs) Handles MyBase.Load        Me.Size = New System.Drawing.Size(253, 228)    End Sub    Private Sub Button2_Click(sender As Object, e As EventArgs) Handles Button2.Click        If Me.Size.Height = 228 Then            Me.Size = New System.Drawing.Size(253, 365)            Button2.Text = "/\ Options /\"        Else            Me.Size = New System.Drawing.Size(253, 228)            Button2.Text = "\/ Options \/"        End If    End Sub    Private Sub Timer2_Tick(sender As Object, e As EventArgs) Handles Timer2.Tick        If CheckBox1.Checked = True Then            Me.TopMost = True        Else            Me.TopMost = False        End If    End SubEnd Class

@tomlambert01

Any other suggestions for the options? 

 

@tmcclelland455

Look better now?

[xox]

Nope, it looks good, very good. I'm impressed.

 

I need to learn C#, it's the language of industry and pretty much everything. I know a bit of C++, although it's rather going out of fashion.

[pspfreak]

Nope, it looks good, very good. I'm impressed.

 

I need to learn C#, it's the language of industry and pretty much everything. I know a bit of C++, although it's rather going out of fashion.

Thank you! 

[LukeTim]

Nope, it looks good, very good. I'm impressed.

 

I need to learn C#, it's the language of industry and pretty much everything. I know a bit of C++, although it's rather going out of fashion.

C++ going out of fashion? That entirely depends what you're doing.

As a Windows Driver developer I can assure you that C++ is very much in popular use!

[xox]

C++ going out of fashion? That entirely depends what you're doing.

As a Windows Driver developer I can assure you that C++ is very much in popular use!

C# is becoming more widespread though

[LukeTim]

C# is becoming more widespread though

As I said, it depends entirely upon what you're doing.

[TizzyT]

Hmm I don't know exactly what or where this issue is because I didn't look at code but I saw something about leading 0s. Since it looks like most things in the program that are displayed are strings I would use the string.trim or trimleft or if needed trimright.

[Nuluvius]

Personally I would perhapse have just wrapped this class: http://msdn.microsoft.com/en-GB/library/system.diagnostics.stopwatch.aspx?cs-save-lang=1&cs-lang=vb#code-snippet-1