VS2013 Bad memory allocation error C++

[themaniac]

I'm getting this error  it points to this part of the code(it says its the line with the closing curly bracket)

for (int i = 4; i != Rank; i--)
{
highScore[i] = highScore[i - 1];
highScoreName[i] = highScoreName[i - 1];
}

 

Here's the rest of it

//Includes the libraries
#include <iostream>
#include <string>
#include <fstream>

//Uses the standard namespace
using namespace std;

//Declares the global variables
int guess;
int winnings;

//Defines the question class
class Question
{
	private:
		string questionText;
		string answerOne;
		string answerTwo;
		string answerThree;
		string answerFour;
		int correctAnswer;
		int prizeAmount; //This determines how much the question is worth
	public:
		void setValues(string q, string a1, string a2, string a3, string a4, int ca, int pa);

		void askQuestion();
};

void main()
{
	//Declares the local variables
	int highScore[5];
	string highScoreName[5];
	int Rank;

	//Initialize a highscore at 0
	highScore[4] = 0;

	//Inputs the highscores from a text file
	ifstream input_HighScores;
	input_HighScores.open("HighScores.txt");
	
	
	for (int i = 0; i < 5; i++)
	{
		input_HighScores >> highScore[i];
		input_HighScores >> highScoreName[i];
	}
	input_HighScores.close();
	if (highScore[4] == 0)
	{
		//Initialize the local variables
		highScore[0] = 20000;
		highScore[1] = 15000;
		highScore[2] = 10000;
		highScore[3] = 5000;
		highScore[4] = 2500;
		highScoreName[0] = "Computer";
		highScoreName[1] = "Computer";
		highScoreName[2] = "Computer";
		highScoreName[3] = "Computer";
		highScoreName[4] = "Computer";
	}

	

	//Shows the title screen
	cout << "*****************" << endl;
	cout << "*               *" << endl;
	cout << "* The Game Show *" << endl;
	cout << "*               *" << endl;
	cout << "*      by       *" << endl;
	cout << "*               *" << endl;
	cout << "*               *" << endl;
	cout << "*               *" << endl;
	cout << "*****************" << endl;
	cout << endl;

	//Creates the instances of the Question class
	Question q1;
	Question q2;
	Question q3;
	Question q4;
	Question q5;
	Question q6;
	Question q7;
	Question q8;
	Question q9;
	Question q10;

	//Sets the values of the question instances
	q1.setValues("What does cout do?", "Eject a CD", "Send Text to the printer", "Print text to the screen", "Play a sound", 3, 2500);
	q2.setValues("What are the two sections in a class?", "Public and Local.", "Global and Local.", "Global and Private.", "Public and Private.", 4, 5000);
	q3.setValues("What does cin do?", "Gets input from a file.", "Gets input from the user.", "Gets input from the computer.", "Gets the letter c.", 2, 2500);
	q4.setValues("When do you use while?", "When you want to loop code while a condition is met.", "When you want to loop code until a condition is met.", "When you want to make a class.", "When you want to put data into a file.", 1, 3000);
	


	//Asks the questions
	q1.askQuestion();
	q2.askQuestion();
	q3.askQuestion();
	q4.askQuestion();

	if (winnings >= highScore[4])
	{
		//Gets the users rank
		for (int i = 4; winnings >= highScore[i] && i >= 0; i++)
		{
			Rank = i;
		}

		//Rearrange the highscore list
		for (int i = 4; i != Rank; i--)
		{
			highScore[i] = highScore[i - 1];
			highScoreName[i] = highScoreName[i - 1];
		}

		cout << "You got a high score" << endl;
		cout << "Enter a name" << endl;
		cin >> highScoreName[Rank];
		highScore[Rank] = winnings;
	}

	//Shows the highscore list
	cout << "High Scores." << endl;
	cout << endl;
	for (int i = 0; i < 5; i++)
	{
		cout << highScore[i] << " " << highScoreName[i] << endl;
	}

	//Outputs the Highscore data to a text file
	ofstream output_HighScores;
	output_HighScores.open("HighScores.txt");

	for (int i = 0; i < 5; i++)
	{
		output_HighScores << highScore[i] << endl;
		output_HighScores << highScoreName[i] << endl;
	}
	output_HighScores.close();
	system("PAUSE");
}

//Stores the values for the Question class variables
void Question::setValues(string q, string a1, string a2, string a3, string a4, int ca, int pa)
{
	questionText = q;
	answerOne = a1;
	answerTwo = a2;
	answerThree = a3;
	answerFour = a4;
	correctAnswer = ca;
	prizeAmount = pa;
}

void Question::askQuestion()
{
	//Makes the question
	cout << endl;
	cout << questionText << endl;
	cout << "1." << answerOne << endl;
	cout << "2." << answerTwo << endl;
	cout << "3." << answerThree << endl;
	cout << "4." << answerFour << endl;
	cout << endl;

	//Asks for the guess
	cout << "What is your answer?" << endl;
	cin >> guess;

	//Adds prizeAmount if the user is correct
	if (guess == correctAnswer)
	{
		cout << endl;
		cout << "You are correct." << endl;
		winnings = winnings + prizeAmount;
		cout << "You just won $" << prizeAmount << endl;
		cout << "Your total winnings is now $" << winnings << endl;
		cout << endl;
	}
	else 
	{
		cout << endl;
		cout << "You are incorrect." << endl;
		cout << "Your total winnings is $" << winnings << endl;
		cout << endl;
	}
}

 

[2FA]

What happens when i = 0 and you try to access 0 - 1? 

[themaniac]

7 minutes ago, DeadEyePsycho said:

What happens when i = 0 and you try to access 0 - 1? 

I still get the error

[2FA]

Just now, themaniac said:

I still get the error

You got to be more specific. I posted in that fashion to make you think about arrays in the sense that you don't want your condition to reach one end of the array and try to access a position that is offset by +1 or -1 beyond the array. It leads to a bad memory access.

 

If you really want your for loop to decrease, increase the size of the array by one and just don't use the 0th position. That's an easy fix.

 

The other option is to rethink your logic in the for loops and/or add some if statements to avoid that.

 

Either way the problem happens when i gets to zero.

[2FA]

for (int i = 4; winnings >= highScore[i] && i >= 0; i++)
		{
			Rank = i;
		}

If I'm reading that correctly, this starts at 4 and keeps increasing which doesn't seem correct. For example, highscore[5] doesn't exist.

[ErickS89]

change int I = 4 to I = 0 and that will solve your issue, I did not run into memory issues with your code tho.  

[themaniac]

31 minutes ago, DeadEyePsycho said:

You got to be more specific. I posted in that fashion to make you think about arrays in the sense that you don't want your condition to reach one end of the array and try to access a position that is offset by +1 or -1 beyond the array. It leads to a bad memory access.

 

If you really want your for loop to decrease, increase the size of the array by one and just don't use the 0th position. That's an easy fix.

 

The other option is to rethink your logic in the for loops and/or add some if statements to avoid that.

 

Either way the problem happens when i gets to zero.

oh ok, also by more specific do you mean an image of the error or something?

25 minutes ago, DeadEyePsycho said:

for (int i = 4; winnings >= highScore[i] && i >= 0; i++)
		{
			Rank = i;
		}

If I'm reading that correctly, this starts at 4 and keeps increasing which doesn't seem correct. For example, highscore[5] doesn't exist.

oops that's supposed to decrease not increase.

 

After running it with it decreasing its working fine