"string indices must be integers"

[Pythons]

Hey,
So I've created a save file using the code:

Attack = 1

data = {

             "Attack:  str(Attack)

            }

jsonData = json.dumps(data)
with open("Savefile.json", 'w') as f:
             json.dump(jsonData, f)

 

But when i try to assign it to a variable using

 

with open('Savefile.json', 'r') as f:
            data = json.load(f)

Attack = data["Attack"]

 

It doesn't assign the 'Attack' to the variable Attack. It instead tells me that "TypeError: string indices must be integers"

Please help!!

[NoRomanBatmansAllowed]

1 minute ago, Pythons said:

Hey,
So I've created a save file using the code:

Attack = 1

data = {

             "Attack:  str(Attack)

            }

jsonData = json.dumps(data)
with open("Savefile.json", 'w') as f:
             json.dump(jsonData, f)

 

But when i try to assign it to a variable using

 

with open('Savefile.json', 'r') as f:
            data = json.load(f)

Attack = data["Attack"]

 

It doesn't assign the 'Attack' to the variable Attack. It instead tells me that "TypeError: string indices must be integers"

Please help!!

Just to be sure, and for other people to help, what language is this?

 

(I'm pretty sure it's python, but I can't be too sure.)

[Pythons]

Just now, bob51zhang said:

Just to be sure, and for other people to help, what language is this?

 

(I'm pretty sure it's python, but I can't be too sure.)

Sorry, I forgot to say that!
Yes, it is python

[LtStaffel]

can we see the whole script please?

[LtStaffel]

oh, and you need to close the " quotes on the line that goes:

"Attack: str(Attack)

[Mr_KoKa]

You encode your dictionary to json, and then you encode that json string to json again resulting in saving single string encoded in json to your file, when reading, you decode it once, so you ending up with a json string, not a dictionary.

 

Btw, python relies on indentation, and your code embedded in your post without code tags looks like garbage.

 

[Pythons]

I had to cut out irrelevant code, the script is pretty long.
attack = 1
data = {
            "Attack":       str(attack),
        }

jsonData = json.dumps(data)

        with open("Savefile.json", 'w') as f:
             json.dump(jsonData, f)
        for i in str(.1):
            time.sleep(int(1))

 

This is to create a file called "Savefile.json"

 

with open('Savefile.json', 'r') as f:
            data = json.load(f)

attack = data['Attack']

for i in str(.1):
       time.sleep(int(1))

 

This is meant to load from a file called "Savefile.json"

 

  File "E:\PYTHON\Savefilecode\Save.py", line 6021, in load
    attack = data["Attack"]
TypeError: string indices must be integers

 

This is the error that i get

 

 

1 minute ago, Mr_KoKa said:

You encode your dictionary to json, and then you encode that json string to json again resulting in saving single string encoded in json to your file, when reading, you decode it once, so you ending up with a json string, not a dictionary.

 

Btw, python relies on indentation, and your code embedded in your post without code tags looks like garbage.

 

Look, I never said that i was any good at this, nor as good as anyone else in this forum. That's why I'm asking for help
I actually hardly know much about this at all, I just need someone to point out the flaws and help me fix them!

[Mr_KoKa]

I'm not judge your code, but the lack of use of code tags, look how much better it looks with code tags:

 

import json

Attack = 1
data = {
  "Attack":  str(Attack)
}

jsonData = json.dumps(data) # Here is '{"Attack": "1"}'
with open("savefile.json", 'w') as f:
  json.dump(jsonData, f) # And now it is '"{\"Attack\": \"1\"}"'

with open('savefile.json', 'r') as f:
  data = json.load(f) # You decode it once and it becomes '{"Attack": "1"}' (a string)
  Attack = data["Attack"] # You're trying to get "Attack" indice of string which can be only indiced by integers from 0 to len(data)-1

 

[Pythons]

7 minutes ago, Mr_KoKa said:

I'm not judge your code, but the lack of use of code tags, look how much better it looks with code tags:

 

import json

Attack = 1
data = {
  "Attack":  str(Attack)
}

jsonData = json.dumps(data) # Here is '{"Attack": "1"}'
with open("savefile.json", 'w') as f:
  json.dump(jsonData, f) # And now it is '"{\"Attack\": \"1\"}"'

with open('savefile.json', 'r') as f:
  data = json.load(f) # You decode it once and it becomes '{"Attack": "1"}' (a string)
  Attack = data["Attack"] # You're trying to get "Attack" indice of string which can be only indiced by integers from 0 to len(data)-1

 

Oh okay, I see your point now
How would I load the Integer from the .json file and then assign it back to a variable?

[Mr_KoKa]

The "saving it" part is wrong. Just ditch this line

jsonData = json.dumps(data) # Here is '{"Attack": "1"}'

 

and change this line

json.dump(jsonData, f) # And now it is '"{\"Attack\": \"1\"}"'

to

json.dump(data, f) # And now it is '"{\"Attack\": \"1\"}"'

 

 

So now you don't encode data to json and save it to jsonData and then encode it again and save to file, but now you just encode your data (dictionary) once right into the file. And then you load it from file as you did, decoding it once. Once encoded once decoded, it just works.

[Pythons]

Thanks!