Code help C#

[l3igwill]

I cannot seem to figure out why the value J isn't stored into the position. In the display line it says that Letter[position] is a unassigned local variable.

This is just one method of a program.

private void CheckCharacter(string userInput) {

         char[] Letter = userInput.ToArray();
         int mostOccurences=0;
         int noTimes = 0;
         int position;

         for (int i = 0; i < Letter.Length; i++) {
            for (int j = 0; j < Letter.Length; j++) {
               if (Letter[j] == Letter[i]) {
                  noTimes++;
               }
               if (noTimes > mostOccurences) {
                  mostOccurences = noTimes;
                  position = j;
               }
            }
         }
         characterLabel.Text = "The " + Letter[position] + " occured the most at " + mostOccurences + " Times.";
           
      }

 

[fizzlesticks]

If "noTimes > mostOccurences" is never true or letter.length is 0, you never set a value for position. To use a variable it must be initialized on every possible path your code may take.

[DXMember]

shouldn't you be like resetting the "noTimes" after each loop

and I would suggest you swap the for-j-loop to be like

for(int j=i, noTimes=0; j<Letter.Length; j++)

 

that way you will reduce the number of necessary iterations in half and your "noTimes" will correctly count only the current letter it's checking instead of all letters

when the "mostOccurences" stays at zero you can just output the first letter as all of them occurred just once

 

as to why your position doesn't get save, I'm not entirely sure if you give it a non empty string it should be fine

[l3igwill]

Already fixed it thanks guys.