Problems with setting up mincecraft server

[Bartandroid123]

I used this tutorial (https://www.youtube.com/watch?v=8ghc71KagTc&t=1316s) to do all the things an my computer first and then tested the server on the same computer and on a laptop in the same network and it worked both on the same pc and in the local network. But later when i was following a port forwarding tutorial (

) i did all the windows defender firewall things but the problem is that my pc is connected to the internet using a powerline cube(the cube that connects to the source is connected to the modem)

the order looks something like this:

 

modem---->powerline source cube------>router

 

and on my friends computer(not in my network) he didint see any server under my ip.

 

thanks in advance

 

 

[Lurick]

Your public IP (the one your ISP gives) or your private IP(the one your PC gets) because if you're giving your friend a 192.168.x.x address then they'll never see it.