Bash Scripting help

[Nymmie]

Trying to make bash script to make handbrake encodes with CLI, but I run into a weird issue when creating folders.

 

Creating directories .sh file

mkdir test1
mkdir test2
mkdir test3

returns

mkdir: cannot create directory 'test1\r': No such file or directory
mkdir: cannot create directory 'test2\r': No such file or directory

And test3 gets created.

 

Same thing happens when I try to escape at EOL with \

 

What am I doing wrong?

[LtStaffel]

8 minutes ago, Nymmie said:

Trying to make bash script to make handbrake encodes with CLI, but I run into a weird issue when creating folders.

 

Creating directories .sh file

mkdir test1
mkdir test2
mkdir test3

returns

mkdir: cannot create directory 'test1\r': No such file or directory
mkdir: cannot create directory 'test2\r': No such file or directory

And test3 gets created.

 

Same thing happens when I try to escape at EOL with \

 

What am I doing wrong?

Semicolons?

[Nymmie]

OK, that works to do with creating the folders, so thats progress, however, terminal output is

./test.sh: line 1 $'\r': command not found
./test.sh: line 2 $'\r': command not found

 

[LtStaffel]

11 hours ago, Nymmie said:

OK, that works to do with creating the folders, so thats progress, however, terminal output is

./test.sh: line 1 $'\r': command not found
./test.sh: line 2 $'\r': command not found

 

Remember to quote or mention me so I get a notification, it's a good thing I checked back manually.

You must have extra special characters (I believe \r is return, or an "enter" keystroke) because it works for me without semicolons even.

 

[Nymmie]

2 hours ago, LtStaffel said:

Remember to quote or mention me so I get a notification, it's a good thing I checked back manually.

You must have extra special characters (I believe \r is return, or an "enter" keystroke) because it works for me without semicolons even.

 

oops... heres a curveball i forgot to mention... doing this on Windows with Linux on Windows Subsystem... and .sh made with notepad.

[LtStaffel]

Just now, Nymmie said:

oops... heres a curveball i forgot to mention... doing this on Windows with Linux on Windows Subsystem... and .sh made with notepad.

It's probably adding the return characters to the end. Try kate editor maybe? It's always been good in all my uses (on any OS)

[Nymmie]

3 hours ago, LtStaffel said:

It's probably adding the return characters to the end. Try kate editor maybe? It's always been good in all my uses (on any OS)

yeah its Windows line endings but when i switch to Unix style i dont get the error, however line 1 ends up as command not found.

[LtStaffel]

5 hours ago, Nymmie said:

yeah its Windows line endings but when i switch to Unix style i dont get the error, however line 1 ends up as command not found.

@Nuluvius Save me

[Nuluvius]

9 hours ago, LtStaffel said:

@Nuluvius Save me

[artizirk]

17 hours ago, Nymmie said:

yeah its Windows line endings but when i switch to Unix style i dont get the error, however line 1 ends up as command not found.

Maybe this is because your script is executable and Windows Linux Subsystem tries to execute the first line differently from the rest of the lines.

I don't have a system handy to test this but try adding a shebang line as first line of your script.

 

something like this

#!/bin/bash

mkdir test1
mkdir test2
mkdir test3

And save the file as a UNIX file because as you already figured out Linux/Unix systems use \n as a line sperator instead of \n\r like Windows does.

[flowalex]

I just wrote a script that would run those same commands, and I got all three to run on Ubuntu 17.04 I haven't tried WSL.  I wrote it in nano, see if you can install that and then try rewriting the script.  

Spoiler

 

Here is what I wrote, like @artizirk said add the shebang line.  Also make sure that the script is executable

# !bin/sh


mkdir test1
mkdir test2
mkdir test3

 

[artizirk]

Linux seems to be pretty happy to run the script with broken shebang line but please

# !bin/bash
 ^ don't add a space here

correct bash shebang should look like this

#!/bin/bash
 ^ No space and it is a full path starting with a /

 

[flowalex]

3 minutes ago, artizirk said:

snip

Yeah, I taught myself an that is how I have always done it.

[Linus_torvalds]

On 10/17/2017 at 3:25 AM, Nymmie said:

Trying to make bash script to make handbrake encodes with CLI, but I run into a weird issue when creating folders.

 

Creating directories .sh file

mkdir test1
mkdir test2
mkdir test3

returns

mkdir: cannot create directory 'test1\r': No such file or directory
mkdir: cannot create directory 'test2\r': No such file or directory

And test3 gets created.

 

Same thing happens when I try to escape at EOL with \

 

What am I doing wrong?

Just install unix2dos and Dos2unix in your linux installation. And run Dos2unix test1 (test1 full path if not in the directory where test1 is located). This will convert windows line endings to linux so \r\n will become \n

\r\n is windows line ending

\n is unix line ending