C# - NullReferenceException was unhandled

[madknight3]

2 minutes ago, AluminiumTech said:

 

if(OnTask_AllowedExtension.Contains(URL) & OnTask_AllowedWebsites.Contains(URL))

 

Normally you'll want to use && and || over & and | because they use short-circuit evaluation.

 

[squirrl]

1 minute ago, AluminiumTech said:

or actually I think I can simplify that further.

 

if(OnTask_AllowedExtension.Contains(URL) & OnTask_AllowedWebsites.Contains(URL))
   {
//Do something here
   }
else if(OnTask_NotAllowedWebsites.Contains(URL))
{
  //Do something here
}

 

 

That changes the logic and introduces another issue. if you're setting onTask to false in the last if statement, you're not changing anything since it's false to start with. You could remove the whole last if statement and have the same functionality.

 

What exactly is the functionality that you want here with the allowed and not allowed URLs?

[AlTech]

Just now, squirrl said:

That changes the logic and introduces another issue. if you're setting onTask to false in the last if statement, you're not changing anything since it's false to start with. You could remove the whole last if statement and have the same functionality.

 

What exactly is the functionality that you want here with the allowed and not allowed URLs?

AHHHH. I'm getting false positives lol.

 

It's telling me it's not allowed even if it is allowed.

[AlTech]

3 minutes ago, madknight3 said:

Normally you'll want to use && and || over & and | because they use short-circuit evaluation.

 

Ok. But it's telling me now that some strings which are "Allowed" are "not allowed"

[squirrl]

Just now, AluminiumTech said:

Ok. But it's telling me now that some strings which are "Allowed" are "not allowed"

Read what I've been posting above. What are you trying to achieve with having a blacklist and whitelist at the same time? And what should happen to URLs which aren't on either list?

[vanished]

Just now, AluminiumTech said:

Ok. But it's telling me now that some strings which are "Allowed" are "not allowed"

If you just want to replace the exact same functionality, try the loop I suggested.  I don't want to discourage you from going for a better option if one exists in this language for your scenario, but it's always there to fall back on

[madknight3]

5 minutes ago, AluminiumTech said:

Ok. But it's telling me now that some strings which are "Allowed" are "not allowed"

Sorry, I was merely providing some information on the operators, not checking to see if your logic was correct or not.

 

Since there have been some changes, how about you post the full OnTask class again.

[AlTech]

33 minutes ago, madknight3 said:

Sorry, I was merely providing some information on the operators, not checking to see if your logic was correct or not.

 

Since there have been some changes, how about you post the full OnTask class again.

   class OnTask
    {
        Dialog dialog = new Dialog();

        public string URL;
        public bool IsOnTask;

        public string[] OnTask_AllowedWebsites = new string[11];
        public string[] OnTask_NotAllowedWebsites = new string[22];
        public string[] OnTask_AllowedExtension = new string[8];

        //Check if the website is in the allowed list
        public void AssignValues()
        {
            OnTask_AllowedWebsites[0] = "onedrive";
            OnTask_AllowedWebsites[1] = "google";
            OnTask_AllowedWebsites[2] = "icloud";
            OnTask_AllowedWebsites[3] = "youtube";
            OnTask_AllowedWebsites[4] = "dropbox";
            OnTask_AllowedWebsites[5] = "microsoft";
            OnTask_AllowedWebsites[6] = "bing";
            OnTask_AllowedWebsites[7] = "gmail";
            OnTask_AllowedWebsites[8] = "linkedin";
            OnTask_AllowedWebsites[9] = "stackoverflow";
            OnTask_AllowedWebsites[10] = "slack";

            OnTask_NotAllowedWebsites[0] = "steampowered";
            OnTask_NotAllowedWebsites[1] = "hub";
            OnTask_NotAllowedWebsites[2] = "amazon";
            OnTask_NotAllowedWebsites[3] = "ebay";
            OnTask_NotAllowedWebsites[4] = "spotify";
            OnTask_NotAllowedWebsites[5] = "linustechtips";
            OnTask_NotAllowedWebsites[6] = "apple";
            OnTask_NotAllowedWebsites[7] = "xbox";
            OnTask_NotAllowedWebsites[8] = "wccftech";
            OnTask_NotAllowedWebsites[9] = "fake";
            OnTask_NotAllowedWebsites[10] = ".con";
            OnTask_NotAllowedWebsites[11] = ".cm";
            OnTask_NotAllowedWebsites[12] = "skype";
            OnTask_NotAllowedWebsites[13] = "ad";
            OnTask_NotAllowedWebsites[14] = "game";
            OnTask_NotAllowedWebsites[15] = "facebook";
            OnTask_NotAllowedWebsites[16] = "instagram";
            OnTask_NotAllowedWebsites[17] = "twitter";
            OnTask_NotAllowedWebsites[18] = "wikipedia";
            OnTask_NotAllowedWebsites[19] = "yahoo";
            OnTask_NotAllowedWebsites[20] = "tube";
            OnTask_NotAllowedWebsites[21] = "red";

            OnTask_AllowedExtension[0] = ".edu";
            OnTask_AllowedExtension[1] = ".org";
            OnTask_AllowedExtension[2] = ".com";
            OnTask_AllowedExtension[3] = ".lithium";
            OnTask_AllowedExtension[4] = ".html";
            OnTask_AllowedExtension[5] = ".info";
            OnTask_AllowedExtension[6] = ".net";
            OnTask_AllowedExtension[7] = ".aspx";
        }

        public void OnTask_TempNavigate()
        {
            AssignValues();

            if (OnTask_AllowedExtension.Contains(URL) && OnTask_AllowedWebsites.Contains(URL))
            {
                IsOnTask = true;
            }
           if (OnTask_NotAllowedWebsites.Contains(URL))
            {
                IsOnTask = false;
           }
        }
    }

Here it is.

[madknight3]

26 minutes ago, AluminiumTech said:

Here it is.

My guess is the problem is what URL contains. In order for Contains(URL) to return true, there has to be an exact match. You can't have a string that matches a value in both the OnTask_AllowedExtension and OnTask_AllowedWebsites arrays.

// Example
URL = "www.google.com"
OnTask_AllowedExtension.Contains(URL) // returns false
// because "www.google.com" is not in the array
// ".com" != "www.google.com"

 

 

[AlTech]

2 minutes ago, madknight3 said:

My guess is the problem is what URL contains. In order for Contains(URL) to return true, there has to be an exact match. You can't have a string that matches a value in both the OnTask_AllowedExtension and OnTask_AllowedWebsites arrays.

// Example
URL = "www.google.com"
OnTask_AllowedExtension.Contains(URL) // returns false
// because "www.google.com" is not in the array
// ".com" != "www.google.com"

 

 

But I only asked for it to look for "Google" in the array. It doesn't look for "Google.com"

[madknight3]

8 minutes ago, AluminiumTech said:

But I only asked for it to look for "Google" in the array. It doesn't look for "Google.com"

It doesn't matter as the logic is still wrong. Here's the example worked out

URL = "Google"

if (OnTask_AllowedExtension.Contains(URL) && OnTask_AllowedWebsites.Contains(URL)) // doesn't get entered
// because OnTask_AllowedExtension.Contains(URL) && OnTask_AllowedWebsites.Contains(URL) doesn't evaluate to true
  
OnTask_AllowedExtension.Contains(URL) // returns false. OnTask_AllowedExtension doesn't contain "Google"
// and
OnTask_AllowedWebsites.Contains(URL) // also returns false because it also doesn't contain "Google".
// Remember, string comparison is case sensitive so "Google" != "google"
  
// even if you used URL = "google"
// OnTask_AllowedExtension.Contains(URL) && OnTask_AllowedWebsites.Contains(URL) still evaluates to false
// because false && true == false