Javascript function not executing on click

SilicateWielder · January 25, 2016

Hey guys, I am trying to write a simple webpage that redirects the user after the correct password is entered. I currently only know javscript so that's what i'm limited to in terms of password verification. When I click Submit the function does not execute or I have written something wrong.

Can anyone tell me what i'm doing wrong and how to fix it?

HTML:

<HTML>	<HEAD>		<TITLE>Personal Web Archive Test</TITLE>		<LINK rel="stylesheet" type="text/css" href="global_style.css">	</HEAD>		<BODY>		<SCRIPT src="login.js"></SCRIPT>				<DIV class="title">			<H1>Personal Archive Sign-in Page</H1>		</DIV>				<TABLE class="main">			<TR>				<TD class="left">left</TD>								<TD class="cent">					<CENTER>						<P>Please enter your password to continue:</P>						<DIV id="error"></DIV>						<P><INPUT name="PassField" type="text">						<BUTTON type="button" onclick="submit();">Submit</BUTTON></P>					</CENTER>				</TD>								<TD class="right">right</TD>			</TR>		</TABLE>			</BODY></HTML>

Javascript:

adminpass = "1234";function submit() {	pasword = document.getElementById("PassField").value;		if (password == adminpass) {		base = window.location.substr(0, window.location.length - 9);		window.location = base + "home.html";	}	else {		document.getElementById("error").textContent = "ERROR: Wrong password.";	}}

Andrew_C · January 25, 2016

Quick look says your PassField needs an ID.

I usually use something like this:

<input type="password" id="l_password" name="l_password" class="input_field" onfocus="wmarkFocus(this, 'Password');" onblur="wmarkBlur(this, 'Password');" value="Password"/>

PS:

function wmarkFocus(txtElem, strWmark) { if (txtElem.value == strWmark)  {  txtElem.value = '';  txtElem.style.color = '#000000';  } }function wmarkBlur(txtElem, strWmark) { if (txtElem.value == '')  {  txtElem.value = strWmark;  txtElem.style.color = '#888888';  } }

PPS:
Does your server support PHP?

TheYoungEnthusiast · January 25, 2016

Line 4 of your Javascript you have a spelling mistake. Missing an 's' in password. Define variable 'pasword' and then do a comparison with variable 'password'.