VB.net Crashing Issues

[spartin503]

So I am making a program with Visual Basic that searches you C drive for a specific file, but when I start the search the program crashes. Here is the code:

 

    Private Sub Button1_Click_1(sender As Object, e As EventArgs) Handles Button1.Click

        Dim di As New DirectoryInfo("C:\")

        Dim files() As FileInfo

        Dim a As Integer

        Do While a = 0

            Try

                files = di.GetFiles("FileName.exe", SearchOption.AllDirectories)

            Catch ex As UnauthorizedAccessException

            End Try

            If Not files Is Nothing Then

                a = 1

            End If

        Loop

        txt_Location.Text = files(0).FullName

    End Sub

 

Any help is welcomed.

[Flynn]

Are you considering symfilelinks that can cause a loop?  (yes windows does have them)

 

 

Also, you are calling a specific inferred class, do you have the system class UnauthorisedAccessException is in?

 

I'm not sure what it is as I'm on a phone and can't look it up, just making sure.

[spartin503]

Are you considering symfilelinks that can cause a loop?  (yes windows does have them)

 

 

Also, you are calling a specific inferred class, do you have the system class UnauthorisedAccessException is in?

 

I'm not sure what it is as I'm on a phone and can't look it up, just making sure.

It's not a problem with symfilelinks with the loop, and I have the class for UnauthorisedAccessException.

 

If I narrow the search field down to a few files for testing it works but when I search the whole drive it crashed.

[JamesThresher]

If the file you are searching for cannot be found then your code will run in an infinite loop.

 

The Do Loop is not neccesary, DirectoryInfo.GetFiles using the option of AllDirectories will search every folder on the C: drive for the file, ordinarily if the file can't be found then it will return a zero length array and "a" will be set to 1 and the loop will exit.

 

However if it hits an area on the disk that causes an UnauthorizedAccessException then "files" will be left as Nothing which will mean you get stuck in an infinite loop.

[spartin503]

If the file you are searching for cannot be found then your code will run in an infinite loop.

The Do Loop is not neccesary, DirectoryInfo.GetFiles using the option of AllDirectories will search every folder on the C: drive for the file, ordinarily if the file can't be found then it will return a zero length array and "a" will be set to 1 and the loop will exit.

However if it hits an area on the disk that causes an UnauthorizedAccessException then "files" will be left as Nothing which will mean you get stuck in an infinite loop.

Ok, I can take out the loop, but when I run the program it finds the first UnauthorizedAccessException in the first folder it searches and then stops. So I can't check beyond %Recycle Bin%. Is there any way I could get around this?

[JamesThresher]

Ok, I can take out the loop, but when I run the program it finds the first UnauthorizedAccessException in the first folder it searches and then stops. So I can't check beyond %Recycle Bin%. Is there any way I could get around this?

 

 Try this.

Public Sub FindFile(ByVal Pattern As String, StartFolder As String)        Dim Results As New Generic.List(Of IO.FileInfo)        Dim StartFolderDirInfo As New IO.DirectoryInfo(StartFolder)        SearchDirectory(Pattern, StartFolderDirInfo, Results)        'Results will contain all matched files    End Sub    Public Sub SearchDirectory(ByVal Pattern As String, SearchFolder As IO.DirectoryInfo, MatchedFilesCollection As Generic.List(Of IO.FileInfo))        Dim Files() As IO.FileInfo = Nothing        Try            Files = SearchFolder.GetFiles(Pattern)        Catch ex As Exception            'Assume a read error of some kind, probably permissions related        End Try        If Files IsNot Nothing AndAlso Not Files.Length = 0 Then            For Each File As IO.FileInfo In Files                MatchedFilesCollection.Add(File)            Next        End If        Dim Directories() As IO.DirectoryInfo = SearchFolder.GetDirectories()        For Each Directory As IO.DirectoryInfo In Directories            SearchDirectory(Pattern, Directory, MatchedFilesCollection)        Next    End Sub