C# array not quite working right

[vorticalbox]

clients class

using System;using System.Collections.Generic;using System.Linq;using System.Text;namespace Squash{    class client    {        public int clientid { get; set; }        public string Name { get; set; }        public int limit { get; set; }        }}

The array Part

int ccount = 0; var clients = new client[100];Console.WriteLine("Enter client name");                        string name = Console.ReadLine();                        clients[ccount] = new client { clientid = ccount};                        clients[ccount] = new client {Name = name};                        Console.WriteLine("ID :" + clients[ccount].clientid + " Name :" + clients[ccount].Name + " Added.");                        ccount++;                        Console.ReadKey();

ID is always 0 when I writing clients to the console.

[RononDex]

Is there a for or foreach loop missing in your code?

As the code stands right now, you always assign 0 to the clientid as ccount is always = 0

[vorticalbox]

Is there a for or foreach loop missing in your code?

As the code stands right now, you always assign 0 to the clientid as ccount is always = 0

under the writeline there is ccount++; which does add 1 to the number as i have it printed at the top of my menu. It is adding the name to a new entity but the ID just isn't going up like i expect it to

[RononDex]

Yes because you are raising ccount AFTER you asigned it to the property clientid.

[vorticalbox]

Yes because you are raising ccount AFTER you asigned it to the property clientid.

yeah the problem is the next entry also has the ID of 0

[Nineshadow]

yeah the problem is the next entry also has the ID of 0

Because the default ID is 0 and you only write to the first element in the array because you never repeat it.

 

You need a for loop.

[Nineshadow]

Don't know about C#, but in C++ :

#include <iostream>using namespace std;struct client {int ID;string name;};struct client clients[100];int main(){    int n;    cout << "Number of clients : ";    cin >> n;    for(int i = 0; i < n;i++)    {        clients[i].ID = i;        cin >> clients[i].name;    }    for(int i = 0; i < n;i++)        cout << clients[i].ID << ' ' << clients[i].name << "\n";    return 0;} 

.

[RononDex]

This is how your code should look like with a loop (Nineshadow's code is C++, not C#

var clients = new client[100];for ( var i = 0; i < clients.Length; i++){    Console.WriteLine("Enter client name");    string name = Console.ReadLine();    clients[i] = new client { clientid = i, Name = name};    Console.WriteLine("ID :" + clients[i].clientid + " Name :" + clients[i].Name + " Added.");}Console.ReadKey();

[madknight3]

You're replacing your first object with a different object.

clients[ccount] = new client { clientid = ccount}; // creating new object, setting the idclients[ccount] = new client {Name = name}; // creating another new, different object, and setting the name (id isn't set)

The ID is always zero because that is the default value of an int property. When you declare your second object, it wont have a value assigned to the id. To fix it, assign all properties at once.

clients[ccount] = new client {clientid = ccount, Name = name};

Just for reference, you could also modify the object after it was created the first time.

clients[ccount] = new client { clientid = ccount}; // create objectclients[ccount].Name = name; // modify object

[RononDex]

 

You're replacing your first object with a different object.

clients[ccount] = new client { clientid = ccount}; // creating new object, setting the idclients[ccount] = new client {Name = name}; // creating another new, different object, and setting the name (id isn't set)

The ID is always zero because that is the default value of an int property. When you declare your second object, it wont have a value assigned to the id. To fix it, assign all properties at once or create the object before you add it to the array.

clients[ccount] = new client {clientid = ccount, Name = name};

I replaced ccount with i (the for loop counter) and missed to replace some ccount calls. Edited and should be fixed.

 

EDIT: Ah sry, I thought you were talking to me lol

[madknight3]

EDIT: Ah sry, I thought you were talking to me lol

 

Nope, but your code also has the same issue I explained.

[RononDex]

Nope, but your code also has the same issue I explained.

 

Urm, I don't think so?

 

EDIT: Ah nevermind, I see what you meant now and fixed it. Damn copy pasting lol

[madknight3]

Urm, I don't think so?

 

It did before you edited it

[Nineshadow]

Nope, but your code also has the same issue I explained.

Sometimes you miss the most f*cking obvious issues...happens so often though.