issue with my Hash

[Mrcrysis2000]

Trying to make a hash function that will take in a name and convert it to ASCII (with a random variable on the end) 

 

#include <iostream>

#include <string>

using namespace std;

 

int hasher(string name)

{

int integer;

    for (int counter = 0; counter >= name.length(); counter++)

    {

        integer = integer + ((int)name[counter] * counter);

    }

    cout << integer;

}

 

int main ()

{

    string name;

    cout << "Input your name";

    cin >> name;

    hasher(name);

}

 

 

Any idea where ive gone wrong and get the same number for any name i put in??

 

Thanks 

[SSL]

Have you stepped through this code in a debugger?

[Midnight]

Check your for loop and your variables.

[Midnight]

Have you stepped through this code in a debugger?

 

Lol, you don't need a debugger for this.

[laxer]

Since people only kind of answered this...

 

The conditional on your for loop is wrong.

[fizzlesticks]

Lol, you don't need a debugger for this.

You never need a debugger, that doesn't mean it won't help you find the problem and do it faster than just staring at the code.

[szomeret]

>= name.length()

should be

< name.length()

[Midnight]

You never need a debugger, that doesn't mean it won't help you find the problem and do it faster than just staring at the code.

 

Not in this case.

[pierrelucsav]

hasher function should look like this:

 

int hasher(string name){    int integer = 0;    for (int counter = 0; counter < name.length(); counter++)    {        integer = integer + ((int)name[counter] * counter);    }    cout << integer;    return integer;}

[SSL]

Not in this case.

 

So debugging wasn't needed, but taking the time to ask on the forum was?