Windows form c#, encryption and adding additional character

[Razhan]

 

Hey man I was trying to do AES on my code, btw it's a windows form. So I did this, I'm able to build but when I debug, visual studio will crash which means there are some problems with the codes I did. Could you provide a sample or correct any mistakes here? Thanks.

 

 class CipherMachine    {        static public string Encrypt    (        string plain = "",        string passPhrase = "Pas5pr@se",        string saltValue = "s@1tValue",        string hashAlgorithm = "SHA1",        int passwordIterations = 2,        string initVector = "@1B2c3D4e5F6g7H8",        int keySize = 256    )        {            byte[] initVectorBytes = Encoding.ASCII.GetBytes(initVector);            byte[] saltValueBytes = Encoding.ASCII.GetBytes(saltValue);            byte[] plainTextBytes = Encoding.UTF8.GetBytes(plain);            PasswordDeriveBytes Password = new PasswordDeriveBytes            (                passPhrase,                saltValueBytes,                hashAlgorithm,                passwordIterations            );            byte[] keyBytes = Password.GetBytes(keySize / 8);            RijndaelManaged symmetricKey = new RijndaelManaged();            symmetricKey.Mode = CipherMode.CBC;            ICryptoTransform encryptor = symmetricKey.CreateEncryptor            (                keyBytes,                initVectorBytes            );            MemoryStream memoryStream = new MemoryStream();            CryptoStream cryptoStream = new CryptoStream            (                memoryStream,                encryptor,                CryptoStreamMode.Write            );            cryptoStream.Write(plainTextBytes, 0, plainTextBytes.Length);            cryptoStream.FlushFinalBlock();            byte[] cipherTextBytes = memoryStream.ToArray();            memoryStream.Close();            cryptoStream.Close();            string cipher = Convert.ToBase64String(cipherTextBytes);            return cipher;        }        static public string Decrypt        (            string cipher,            string passPhrase = "Pas5pr@se",            string saltValue = "s@1tValue",            string hashAlgorithm = "SHA1",            int passwordIterations = 2,            string initVector = "@1B2c3D4e5F6g7H8",            int keySize = 256        )        {            byte[] initVectorBytes = Encoding.ASCII.GetBytes(initVector);            byte[] saltValueBytes = Encoding.ASCII.GetBytes(saltValue);            byte[] cipherTextBytes = Convert.FromBase64String(cipher);            PasswordDeriveBytes Password = new PasswordDeriveBytes            (                passPhrase,                saltValueBytes,                hashAlgorithm,                passwordIterations            );            byte[] keyBytes = Password.GetBytes(keySize / 8);            RijndaelManaged symmetricKey = new RijndaelManaged();            symmetricKey.Mode = CipherMode.CBC;            ICryptoTransform decryptor = symmetricKey.CreateDecryptor            (                keyBytes,                initVectorBytes            );            MemoryStream memoryStream = new MemoryStream(cipherTextBytes);            CryptoStream cryptoStream = new CryptoStream            (                memoryStream,                decryptor,                CryptoStreamMode.Read            );            byte[] plainTextBytes = new byte[cipherTextBytes.Length];            int decryptedByteCount = cryptoStream.Read            (                plainTextBytes,                0,                plainTextBytes.Length            );            memoryStream.Close();            cryptoStream.Close();            string plain = Encoding.UTF8.GetString            (                plainTextBytes,                0,                decryptedByteCount            );            return plain;        }    }}

Btw, when doing AESManaged or RijndaelManaged, is it a must to put in this?

using System.IO;using System.Security.Cryptography;

Thanks for all your help!

 

 

Ok, so first, the easy question

 

In the code you are using MemoryStream, so yes, you need the using for System.IO. Also, RijndaelManaged (and many other classes in your code) are from System.Security.Cryptography, so both usings are a must

 

Regarding the code, I think it is Ok. I have created a simple program calling your CipherMachine:

using System;class Program{    static void Main(string[] args)    {        string plain = "This is the text to cipher";        string pass = "This is the pasphrase";         string encrypted = CipherMachine.Encrypt(plain, pass);        string decrypted = CipherMachine.Decrypt(encrypted, pass);        Console.WriteLine("PlainText: {0}", plain);        Console.WriteLine("Passphrase: {0}", pass);        Console.WriteLine("Encrypted text: {0}", encrypted);        Console.WriteLine("Decrypted text: {0}", decrypted);        Console.ReadLine();    }}

And it seems to work:

PlainText: This is the text to cipherPassphrase: This is the pasphraseEncrypted text: KqyR4MLVrFfdWw+BcLRoqs+ijzMTJE/Nbn/X5+JDq/k=Decrypted text: This is the text to cipher

I only removed an extra } at the end of your code