[C++] How to convert an int to a char?

[FakezZ]

So I have made a program that takes a number in decimal (integers only for now) and converts it to binary. So the thing is that I have tried using char x [somenumber] = (char) b, but the output is something weird like xm؀ . Any suggestions? Btw, here is the code:

#include <iostream>#include <fstream>#include <cmath>#include <cstring>char* reverse(char v[1024]){  int y = strlen(v);  for (int n = 0; n < y/2; n++)    {      v[n] = v[y-n];    }  return v;}int main(){  int a,b = 0,d,counter = 1;  std::cout << "Please input the number that you want converted to binary(in decimal ofc)" << std::endl;  std::cin >> a;char x[1024];  while (b > 2)    {      b = a % 2;      a = b;      x [counter] = (char) b;      counter = counter++;    }std::string binarynumber(x);  std::cout << "The decimal you entered is equal to: " << binarynumber << " in binary :)" << std::endl;  return 0;}

I am not using reverse() yet, so I can see where the problem is.

[wolfsinner]

Every variable in C is a number. Characters hold the ASCII code of a character. 0 and 1 are not the ASCII code for the characters "0" and "1".

 

If you add 48 to b, you should obtain what you want.

[FakezZ]

Every variable in C is a number. Characters hold the ASCII code of a character. 0 and 1 are not the ASCII code for the characters "0" and "1".

 

If you add 48 to b, you should obtain what you want.

Even after that, the output is x]Q  when the input is 436347...

[wolfsinner]

Ok, I didn't even look at your conversion code, my bad. Your conversion method is wrong. You're not dividing a by 2 effectively, your cycle will only run once.

Something like this should be correct (untested):

int bits = 0;for(int tmp = a; tmp > 0 ;tmp>>=1, bits++);while (bits){     x[--bits] = (char)(a % 2 + 48);     a /=2;}

This is valid for positive integer values.

[FakezZ]

Ok, I didn't even look at your conversion code, my bad. Your conversion method is wrong. You're not dividing a by 2 effectively, your cycle will only run once.

Something like this should be correct (untested):

int bits = 0;for(int tmp = a; tmp > 0 ;tmp>>=1, bits++);while (bits){     x[--bits] = (char)(a % 2 + 48);     a /=2;}

This is valid for positive integer values.

Thanks that worked