errors in c++

[g0ated]

<#include <iostream>

 

int main(){

    char choice = '\0';

        std::cout << 'Running bootloader...' << std::endl;

        std::cin << 'Pick an option to boot into OS, BIOS or Shell by typing: o, b, s\n'

        if (choice == 'o'){

            std::cout << 'Booting into OS...' << std::endl;

 

        }

        if (choice == 'b'){

            std::cout << 'Booting into BIOS' << std::endl;

        }

        else if (choice == 's'){

            std::cout << 'Booting into Shell' << std::endl;

        }

 

        else{

            while (choice != 'o' or choice != 'b' or choice != 's'){

            std::cout << 'Input was incorrect please try again';

            }

        }

    }

   >

the errors I am getting is shown below in the screenshot(I am using the mingw compiler):

[Electronics Wizardy]

cin should be used like:

 

cin >> "test";

 

The arrows point different ways for cin and cout.

[g0ated]

34 minutes ago, Electronics Wizardy said:

cin should be used like:

 

cin >> "test";

 

The arrows point different ways for cin and cout.

oh whoops ty

[g0ated]

still have the errors though

[Eigenvektor]

33 minutes ago, swabro said:

still have the errors though

Please use code tags, makes stuff more readable.

 

std::cout << 'Booting into OS...' << std::endl;

You're using the wrong quotations marks here. You need to use double quotes for a string, so:

std::cout << "Booting into OS..." << std::endl;

 

A single quote is for a single character (e.g. 'a'). For a string, i.e. multiple characters, you need to use "string" instead. As the compiler is telling you, your "character constant is too long", meaning you're trying to fit multiple characters into a char, which only accepts a single character.

[BobVonBob]

1 hour ago, Electronics Wizardy said:

cin >> "test";

That's wrong too.

 

How is the entered value supposed to get into the choice variable? std::cin needs a variable, not a string for a prompt. If you want a prompt print it using std::cout (without a line ending) and use

std::cin >> choice;

to put the value in choice.

 

Your while loop is also wrong. Right now it's just going to print "Input was incorrect please try again" forever. It won't prompt for a value again and it won't make it back up to where you process the choice variable.

[Eigenvektor]

1 hour ago, BobVonBob said:

Your while loop is also wrong. Right now it's just going to print "Input was incorrect please try again" forever. It won't prompt for a value again and it won't make it back up to where you process the choice variable.

Nice catch! I went over the line and just though it was unnecessarily verbose (why check the same options again) but didn't notice it was actually an endless loop

 

Here's a working version (tested with "g++ choice.cpp -o choice")

Spoiler

#include <iostream>

int main()
{
    char choice = '\0';

    std::cout << "Running bootloader..." << std::endl;

    while (choice == '\0')
    {
        std::cout << "Pick an option to boot into OS, BIOS or Shell by typing: o, b, s" << std::endl;
        std::cin >> choice;

        if (choice == 'o')
        {
            std::cout << "Booting into OS..." << std::endl;
        }
        else if (choice == 'b')
        {
            std::cout << "Booting into BIOS" << std::endl;
        }
        else if (choice == 's')
        {
            std::cout << "Booting into Shell" << std::endl;
        }
        else
        {
            std::cout << "Input was incorrect please try again" << std::endl << std::endl;
            choice = '\0';
        }
    }
}

 

 

[g0ated]

ty you so much for all your help guys

[HelloPeople]

just a suggestion, why aren't you using SWITCH for this?

[Vicarian]

8 hours ago, HelloPeople said:

just a suggestion, why aren't you using SWITCH for this?

switch vs if... else if... else structures are just a matter of preference.  They're functionally the same when compiled.  Both cause branching to occur.  I kind of dislike the additional keywords needed for switch statements, for example.  Still need to use braces, so technically less typing and line breaks needed for the if... else if... else structure.  And most IDEs/editors seriously freak when trying to copy/paste multiple switch cases, especially VS Code.  Fixing indentation isn't my idea of a good time.

[g0ated]

21 hours ago, HelloPeople said:

just a suggestion, why aren't you using SWITCH for this?

I don't think that using the <switch> statement is necessary for just three choices

[g0ated]

12 hours ago, Vicarian said:

switch vs if... else if... else structures are just a matter of preference.  They're functionally the same when compiled.  Both cause branching to occur.  I kind of dislike the additional keywords needed for switch statements, for example.  Still need to use braces, so technically less typing and line breaks needed for the if... else if... else structure.  And most IDEs/editors seriously freak when trying to copy/paste multiple switch cases, especially VS Code.  Fixing indentation isn't my idea of a good time.

ty for the clarification 

[HelloPeople]

16 hours ago, Vicarian said:

switch vs if... else if... else structures are just a matter of preference.  They're functionally the same when compiled.  Both cause branching to occur.  I kind of dislike the additional keywords needed for switch statements, for example.  Still need to use braces, so technically less typing and line breaks needed for the if... else if... else structure.  And most IDEs/editors seriously freak when trying to copy/paste multiple switch cases, especially VS Code.  Fixing indentation isn't my idea of a good time.

switch makes the code cleaner and easier to read IMO. 

[g0ated]

19 hours ago, HelloPeople said:

switch makes the code cleaner and easier to read IMO. 

u are right but the reason I am not using for three conditionals its not really worth it correct me if I am wrong though

[HelloPeople]

3 minutes ago, swabro said:

u are right but the reason I am not using for three conditionals its not really worth it correct me if I am wrong though

you are not wrong. its a matter of preference. 

 

for me readable/easy to read codes are very important. 

so I tend to use switch case more than if/else when there's 3 or more conditions.

[g0ated]

18 minutes ago, HelloPeople said:

you are not wrong. its a matter of preference. 

 

for me readable/easy to read codes are very important. 

so I tend to use switch case more than if/else when there's 3 or more conditions.

I agree this tends to be a very subjective thing and in coding and in my life I am not very organized