Java: Need help correcting code! (Short)

[Aegis_Titan]

I can't seem to find where's the problem, if anyone could help would be appreciated! 

Basically what it has to do is output all negative numbers in the list.

code here -> https://pastebin.com/yU5WY0DG

[SquintyG33Rs]

where do you get an error?

 

what's nptr on line 85? i don't think it's initiated in this scope

 

that's the only thing i see

 

edit: to clarify i see that nptr is a node you make a bit lower but if i'm not mistaken line 85 will be called outside of that and they don't share the value's scope. the functions of a class don't share instantiated variables.

[Aegis_Titan]

Im helping friend out with the code, personally I don't have an insight in programming, if you could write a small correction in it I would appreciate it! :3

[reniat]

 

2 hours ago, Aegis_Titan said:

if you could write a small correction in it I would appreciate it!

It won't really help your friend learn how to code if we just write a fix and send it his/her way. I'll explain what is currently going wrong, and let them learn by implementing the fix themselves.

 

the first problem is that when inserting new elements into the linked list, they are not setting the next node for the end node, meaning the doubly linked list isn't circularly linked.

The next issue is that is the display() method is not currently accounting for the linked list being circular, so once the first issue is fixed they'll need to address that to avoid an infinite loop.

[Aegis_Titan]

thank you!