Can someone explain to me why this wont work? [Java]

[IvanSnipedYu]

Trying to print out all the upper case letters in a string.

 

import java.util.Scanner;

public class HW05P04 {

	private static int x;

	public static void main(String[] args) {
		Scanner input = new Scanner(System.in);
		
		System.out.print("Enter a string: ");
		String a = input.nextLine();
		
		int k = a.length();
		
		System.out.print("Uppercase Letters: ");
		
		int x = 0;
		char position;
		do{
			position = a.charAt(x);
		if(Character.isUpperCase(position)){
			System.out.print(position);
		}
		x++;
		}while(x <= k);
		
	}

}

 

[IvanSnipedYu]

sorry, posted the wrong one. How come this wont work?

import java.util.Scanner;

public class HW05P04 {

	public static void main(String[] args) {
		Scanner input = new Scanner(System.in);
		
		System.out.print("Enter a string: ");
		String a = input.nextLine();
		
		int k = a.length();
		
		int x = 0;
		char position;
		do{
			position = a.charAt(x);
		if(Character.isUpperCase(position)){
			System.out.print(position);
		}
		x++;
		}while(x >= k);
			}
		


		}

 

[rexist]

your condition for do...while loop is wrong

let's say your input's string is = "This App Won't worK"

the length would be 19

if your x start from 0 to <= 19 that would be 20 loops for only 19 characters.

the first 1 was already close thou.

it should be while(x<k)

[IvanSnipedYu]

3 minutes ago, rexist said:

your condition for do...while loop is wrong

let's say your input's string is = "This App Won't worK"

the length would be 19

if your x start from 0 to <= 19 that would be 20 loops for only 19 characters.

the first 1 was already close thou.

it should be while(x<k)

OMG how could I be so dumb. That was like right in front of me this whole time!