Video Attachments Break When Editing Post

[theDapperFoxtrot]

Browser, version and OS: Chrome, Version 85.0.4183.121 (Official Build) (64-bit), Windows 10

 

Steps to reproduce/what were you doing before it happened?

- Upload a .mp4

- Attaches properly, but does not allow text formatting unless you leave white space beforehand

- Posted, then tried to edit post to add text. Allowed me to add text, but broke video upload (auto replaced with download link)

 

What happened?

- Cannot delete broken video

 

What did you expect to happen?

- Upload video, and be able to format to the left or right of it to add text above or below.

 

Link to a page where it happened, if applicable: 

Screenshots of the issue, if applicable: 

 

Any other relevant details:

Each time you activate the edit option, several lines of white space are automatically added above and below lines of text, as shown in the screen shot above.

 

If it's a cloudflare error, what was the ray ID from the bottom of the error page? 

[colonel_mortis]

Did you do all of your editing of that post in Chrome? For some reason, when you first edited the post, you somehow managed to get the internals of the video element (the attachment link and some other stuff that makes it work) to fall out of the video, and I think that may be what's happening in your screenshot there too. However, I can't reproduce that in Firefox or Chrome, and it would be super weird for it to do that.

 

Do you remember if the attachment link showed up in the editor the first time you edited it, or only after you submitted?

[theDapperFoxtrot]

Yes I did it all in Chrome. To be honest I didn't notice it until after I submitted the edit.

 

You'll see on the post now, that there's a second video attachment, and it appears to be broken also, but if I scroll up the thread, and then back down to my post, it loads?

 

Super weird, indeed!

[colonel_mortis]

8 hours ago, theDapperFoxtrot said:

Yes I did it all in Chrome. To be honest I didn't notice it until after I submitted the edit.

 

You'll see on the post now, that there's a second video attachment, and it appears to be broken also, but if I scroll up the thread, and then back down to my post, it loads?

 

Super weird, indeed!

Yeah, the second one is being broken by the first one (it's trying to lazy load the videos when they scroll into view, but the top video is broken and causes it to throw an exception so it never gets to the second video; when you scroll down again, it thinks it's already dealt with the first video so it just tries the second, causing it to work).

 

I will ask IPS to be more defensive in that code, but I have no idea how it managed to actually get into that state in the first place.