Java programming help!

[Watashi]

My code continues to read in the "done" value that I punch in, and it returns it. Here's my code

public static String console2 (String PrereqString)
{
Scanner console = new Scanner(System.in);
int number = 1;
String prereqs = "";
while(!prereqs.equals("done")){
   System.out.print("List pre-requisite#" + number + "(enter done, if finished with prerequisites):");
   prereqs = console.nextLine();
   number = number + 1;     
   PrereqString = PrereqString + " " + prereqs;
}

return PrereqString;
}

[xriqn]

So is it just outputting the value that you set for "done"?

[reniat]

could you be more specific about what your desired behavior is and what you are actually getting? Is it that you're seeing "done" in the returned string when you don't want it to be?

[DtrollMC]

public static String console2 (String PrereqString)
{
Scanner console = new Scanner(System.in);
int number = 1;
String prereqs = "";
while(!prereqs.equals("done")){
   System.out.print("List pre-requisite#" + number + "(enter done, if finished with prerequisites):");
   prereqs = console.nextLine();
   number = number + 1;     
   PrereqString = PrereqString + " " + prereqs;
}

return PrereqString;
}

You should use code blocks to make the code more visible.

 

I don't understand what this code should be doing, but I see a problem with this line:

PrereqString = PrereqString + " " + prereqs;

Variables need to have a lower case name. preReqs or prereqs. In Java, Class names are capitalized, so this whole line syntactically is incorrect. 

 

I'd suggest the following:

public static String console2(String preReq) {
    Scanner console = new Scanner(System.in);
    
    int n = 1;
    String input = "";

    while (!input.equals("done")) {
        System.out.println("...");
        input = console.nextLine();
        n++;

        preReq = preReq + " " + input;
    }

    return preReq;
}

 

I don't understand the code, but this code works and stops when done is entered:

import java.util.Scanner;

class Testst {

    public static String console2(String preReq) {
        Scanner console = new Scanner(System.in);
        
        int n = 1;
        String input = "";

        while (!input.equals("done")) {
            System.out.println("...");
            input = console.nextLine();
            n++;

            preReq = preReq + " " + input;
        }

        return preReq;
    }

    public static void main(String[] args) {
        console2("test");
    }
}

 

[reniat]

managed to double post. oopsie.

[reniat]

1 hour ago, DtrollMC said:

Variables need to have a lower case name. preReqs or prereqs. In Java, Class names are capitalized, so this whole line syntactically is incorrect. 

this is good practice according to the standard java style guidelines, but it is not a language requirement. Not to mention certain best naming practices (like constant variables should be entirely capitalized) break the rule as you described.

 

To be clear I'm not disagreeing that variables should almost always be lower case, I'm just trying to point out that its a standards issue not an actual syntactical req 

[DtrollMC]

3 minutes ago, reniat said:

this is good practice according to the standard java style guidelines, but it is not a language requirement. Not to mention certain best naming practices like constant variables should be entirely capitalized break the rule as you described.

 

To be clear I'm not disagreeing that variables should almost always be lower case, I'm just trying to point out that its a standards issue not an actual syntactical req 

I would argue constants are a different case, as you wouldn't have a class with all caps. The best naming practices can go a long way in telling others what something in your code does. Always good to preach the best practices

[reniat]

22 minutes ago, DtrollMC said:

Always good to preach the best practices

definitely don't disagree with that. I just want to make it clear that they should do that for legibility reasons, not just because they think their code will have errors if they don't adhere to them.

[wasab]

Coding style are up to the organizations and individuals. My professor actually requires the students to underscore all global variables.

 

Different companies/organizations may demand you adhere to their own coding styles. It is not set in stone. 

[Neftex]

id suggest using breakpoints to look why the comparison is failing you/ what else is wrong. using this is gonna help you more in the long run than someone else fixing your code

[loidsemus]

9 hours ago, wasab said:

My professor actually requires the students to underscore all global variables.

He shouldn't. You know there's a thing called naming conventions, and teachers should teach according to them. (If you're not talking about constants, which can be named LIKE_THIS)

[wasab]

1 hour ago, LoidSemus said:

He shouldn't. You know there's a thing called naming conventions, and teachers should teach according to them. (If you're not talking about constants, which can be named LIKE_THIS)

_privateVar

this is what i meant by underscore. He is only professor part time. His full time job is actually senior software engineer and that is the style of his company. There is no single rule for naming. Organization can easily create their own naming rules so its members can easily comprehend one another's code which is the purpose of having these rules in the first place. 

 

you realize the rule but you failed to understand why they are there in the first place.