What's wrong with this batch code?

[Underi]

I created a little batch program to launch different apps on my usb and it worked on my fathers laptop (windows 7) fine, but now that I try it on my windows 10 machine, it closes itself automatically. I don't get it. 

FYI, "peli" means game "jatka" means continue. I've made it so that if loop equals yes, it will tell the user that entering 6 will close the program. This is so that I can launch multiple programs without launching this batch thingy again and again.

@echo off
color a
cls
:jatka
echo Valitse ohjelma.
if %loop%=yes (echo Poistuaksesi valitse 6.)
SET /P peli="1 Steam | 2. Techniclauncher | 3. Pokemon uranium | 4. Interwebz | 5. Backup"
if "%peli%"=="1" (start /d "%~d0\Steam" Steam.exe)
if "%peli%"=="2" (start /d "%~d0\Portable Minecraft" TechnicLauncher.exe)
if "%peli%"=="3" (start /d "%~d0\Pokemon Uranium" Uranium.exe)
if "%peli%"=="4" (start /d "%~d0\Interwebz" HyperFusioncC2vGE3mnz.exe)
if "%peli%"=="5" (start /d "%~d0" Backup.bat)
if %peli%==6 (exit)
cls
set loop=yes
goto jatka

 

[piemadd]

4 minutes ago, Underi said:

I created a little batch program to launch different apps on my usb and it worked on my fathers laptop (windows 7) fine, but now that I try it on my windows 10 machine, it closes itself automatically. I don't get it. 

FYI, "peli" means game "jatka" means continue. I've made it so that if loop equals yes, it will tell the user that entering 6 will close the program. This is so that I can launch multiple programs without launching this batch thingy again and again.

@echo off
color a
cls
:jatka
echo Valitse ohjelma.
if %loop%=yes (echo Poistuaksesi valitse 6.)
SET /P peli="1 Steam | 2. Techniclauncher | 3. Pokemon uranium | 4. Interwebz | 5. Backup"
if "%peli%"=="1" (start /d "%~d0\Steam" Steam.exe)
if "%peli%"=="2" (start /d "%~d0\Portable Minecraft" TechnicLauncher.exe)
if "%peli%"=="3" (start /d "%~d0\Pokemon Uranium" Uranium.exe)
if "%peli%"=="4" (start /d "%~d0\Interwebz" HyperFusioncC2vGE3mnz.exe)
if "%peli%"=="5" (start /d "%~d0" Backup.bat)
if %peli%==6 (exit)
cls
set loop=yes
goto jatka

 

Put in a pause before voto Jatakas and you should be able to see all errors

[vorticalbox]

8 minutes ago, Underi said:

if %loop%=yes (echo Poistuaksesi valitse 6.)

change this to 

 

if /I "%loop%"=="yes" (echo Poistuaksesi valitse 6.)

just tested here and it runs fine, didn't check anything else as that don't exist on my system

 

edit: the /I makes it case insensitive. 

[Underi]

Just now, vorticalbox said:

change this to 

 

if /I "%loop%"=="yes" (echo Poistuaksesi valitse 6.)

just tested here and it runs fine, didn't check anything else as that don't exist on my system

Yeah I just noticed that is the problem. Thanks a lot for the fix!