What do you think

[oliverjrose99]

hi

 

i recently finished my first project, i basic two number calculator and wanted to know what you think, where i could improve, etc.

 

https://www.dropbox.com/s/g6rcxpyi8p7d1cs/calculator.py (it wouldn't let me upload it here)

 

i could add more thing to info but meh

 

thanks

[random314]

It's a good start. What you should do next is look for places where the same code is used and see if you can factor then out. For example the same code is used to get the two numbers used. You could factor this out into a function, which you call to get both numbers

 

Here's a concrete example:

def get_number(message):    while True:        try:            number = float(input(message));            return number        except ValueError:            print("Not valid, try again")first_number = get_number("Enter the first number")second_number = get_number("Enter the second number")

[Guest]

if you have time you could learn to use PyGame and make a UI for this calculator, it may take some work getting to know PyGame buts its pretty useful if you want to continue using python.

[oliverjrose99]

random314 wouldn't that make an infinite loop or is that what the return is for

[random314]

That's right, the while makes an infinite loop which is broken out of using the return statement

[oliverjrose99]

ok thanks alot