BATCH - loop performs twice

[Dogway]

Hello, I have made a script to encode images in one folder.

The problem is that for some reason when input format is not the same as output format the loop applies to the new created file as well, hence creating 2 output files for the same input file. I'm not sure, I thought "FOR %%I" gets validated at parse time.

SET mSize=50%%SET outputformat=pngSET linear=trueIF %linear% EQU true (goto linear)IF %outputformat% NEQ "png" (SET Encode=-quality 90) ELSE (SET Encode=-compress Lossless png:compression-level=9) :linearECHO.ECHO Creating the Down-sampled image with output sharpening, please wait ...FOR %%I IN ( *.jpg, *.jpeg, *.png, *.tif, *.tiff, *.bmp ) do convert -quiet "%%~nxI" -filter Spline -distort resize ^%mSize% -colorspace sRGB %Encode% "%%~nI_New.%outputformat%"

[MrLewisMHarris]

Why don't you just take ".png" out of the input file list? Unless you needed to compress I don't see you you'd need to do this.

[Dogway]

I don't get your point. If I take out .png as input then I won't be able to process png files...

[fizzlesticks]

The *.xxx get done separately, it does all the loops for *.jpg then calculates and loops for *.jpeg then the next thing and so on.  You should be able to fix it by putting *.png as the first type. But of course if you ever change the output format it will break again so I'm not really sure about a permanent solution.

[Dogway]

I see, so that's how it works as I feared. I also thought about how to deal with this, I thought on first detecting the input extension and adding it as an exclusion to the "FOR" command. But I'm not sure how I can parse input extension without a FOR call...

If any I might do this in AHK. I always crash on trying to do things in BATCH 

[fizzlesticks]

You could always create a new directory for the new files.

[Dogway]

I guess so. I will do that then.

 

edit: I just created a folder, moved back and deleted. Hacky but works.

 

md "%foldername%"

move /y "%foldername%\*.*" "./"
rd /s /q "%foldername%"