Monty's bridge

[Classic-master]

hi there i came up with this cool little program i made a little while back.you can use it if you want it's pretty cool and i was looking for some input or advice or cool little things to add. (don't go crazy i'm just starting out.) Thanks!

notes:

only windows 10

python 3.7 

made in idle

you can remove the shutdown prompt and it'll work on any other OS with python 3.7 i think

main.py

[reniat]

for starters, 

import subprocess
subprocess.call(["shutdown", "/r"])

will restart the host operating system, not close the python script. You probably want 

import sys

sys.exit()

 

Also, it's good practice to put all your imports at the top of the file instead of throughout the middle. It can make tracking down dependency trees easier among other things.

 

Also, if you want the user to be able to see your fancy ascii bridgekeeper or the "you shall not pass" message in a shell window (e.g. if you run the .py script outside of idle or another IDE), you could put 

input("Press enter to close")

at the end to keep the window open until they close it. Otherwise as soon as you reach the end of the script it will close and they won't see it.

 

Finally using good variable names is a good habit to get into. dn and dx aren't very clear names. What are they? What do they represent? name and quest would be much clearer. Also, dat should probably be date. It's one extra letter, but it removes any confusion by being fully spelled out, instead of "Is it data? date? datsun?"

[Classic-master]

5 hours ago, reniat said:

for starters, 

import subprocess
subprocess.call(["shutdown", "/r"])

will restart the host operating system, not close the python script. You probably want 

import sys

sys.exit()

 

Also, it's good practice to put all your imports at the top of the file instead of throughout the middle. It can make tracking down dependency trees easier among other things.

 

Also, if you want the user to be able to see your fancy ascii bridgekeeper or the "you shall not pass" message in a shell window (e.g. if you run the .py script outside of idle or another IDE), you could put 

input("Press enter to close")

at the end to keep the window open until they close it. Otherwise as soon as you reach the end of the script it will close and they won't see it.

 

Finally using good variable names is a good habit to get into. dn and dx aren't very clear names. What are they? What do they represent? name and quest would be much clearer. Also, dat should probably be date. It's one extra letter, but it removes any confusion by being fully spelled out, instead of "Is it data? date? datsun?"

wow thanks man! oh and the aim of the program is to shutdown the computer if awnsered incorrectly

oh and i was just using random variables cause it was so short and i had like 30 minutes and the wizard was eating up a lot of that.