Unity Issue (C#)

[TurbulentWinds]

I'm trying to get a simple map generation script to work. Here's my code:

 

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class GenerateLevel : MonoBehaviour {

	public GameObject square;
	public GameObject[,] map; 

	void Start () 
	{
		GenerateMap (20, 10);
	}

	public void GenerateMap (int x, int y) 
	{
		for (int a = 0; a < x; a++) 
		{
			for(int b = 0; b < y; y++) 
			{
				Vector3 vect = new Vector3 (a, b, 0);
				GameObject tile = (GameObject)Instantiate(square, vect, Quaternion.identity, this.transform);
				map [a, b] = tile;
			}
		}
	}
}

Basically, I have this script attached to an object in the scene and have a valid prefab reference to the "square." I have no other code or scripts but this. When I run the scene, the program begins to gobble RAM until it crashes. A couple of times, it spawn one square and said that there was an null object reference to tile at "map [a, b] = tile;"

 

Please help.

[charles245]

I'll go test it myself to be sure, but it looks like you forgot to initalize your 2D array upon calling the GenerateMap function.

[_digital]

I was thinking that as well, just initialize it right before your for loop in GenerateMap

[TurbulentWinds]

Just now, charles245 said:

I'll go test it myself to be sure, but it looks like you forgot to initalize your 2D array upon calling the GenerateMap function.

I just found the problem, I did:

for(int b = 0; b < y; y++)

and not:

for(int b = 0; b < y; b++)

However, I still am having a problem with this:

"null value found where object instance required at line 23"

[TurbulentWinds]

2 minutes ago, charles245 said:

I'll go test it myself to be sure, but it looks like you forgot to initalize your 2D array upon calling the GenerateMap function.

Oh ok, now I get what you are saying. I'll go test that.

[charles245]

4 minutes ago, TurbulentWinds said:

I just found the problem, I did:

for(int b = 0; b < y; y++)

and not:

for(int b = 0; b < y; b++)

However, I still am having a problem with this:

"null value found where object instance required at line 23"

Oh, of course! Can't believe I ran right past that myself. Anyways, to fix the other error just initalize the array in the function.

map = new GameObject[x, y];

[TurbulentWinds]

3 minutes ago, charles245 said:

I'll go test it myself to be sure, but it looks like you forgot to initalize your 2D array upon calling the GenerateMap function.

Yep. That was issue number 2. Thanks!