C++ Whats wrong

[z3kron]

#include <iostream>

#include <cmath>

 

using namespace std;

 

void main()

{

float m,n,xpm,xgm,xpn,xgn,hx1,hx2,a,sum;

cout << "Type in xpm ir xgm: " << endl;

cin >> xpm >> xgm;

cout << "Type in xpn ir xgn" << endl;

cin >> xpn >> xgn;

cout << "Type in hx1 ir hx2: " << endl;

cin >> hx1 >> hx2;

m = xpm;

n = xpn;

sum = 0;

a = 0;

while (n>=m>0)

{

for (m = xpm; m >= xgm; m = m + hx1)

{

for (n = xpn; n >= xgn; n = n + hx2)

{

a = (m*m) / (n - m);

sum = sum + a;

}

 

}

 

 

}

cout << "A: " << a << endl;

cout << "Suma: " << sum << endl;

 

 

}

 

Doing this for college and this just makes my head hurt because i get this. When i run it when i type in the numbers it gives an answer 0.

Why can anyone solve plz

[79wjd]

@z3kron

Well, for the starters, use actual names for your variables....names that describe what they do, thats just brutal to read. 

 

Also, your while loop won't work. Do:

while(n>=m && m >0)

P.s. whats the code supposed to do?

[madknight3]

Also, please use code tags.

 

edit: Thanks for the edit. Proper spacing is helpful too

[z3kron]

@z3kron

Well, for the starters, use actual names for your variables....names that describe what they do, thats just brutal to read. 

 

Also, your while loop won't work. Do:

while(n>=m && m >0)

P.s. whats the code supposed to do?

 

Well im really new to this and im doing this just to work.All the polishing will come in later.

 

So while(n>=m && m >0) how should this look like? && means?

[79wjd]

Well im really new to this and im doing this just to work.All the polishing will come in later.

 

So while(n>=m && m >0) how should this look like? && means?

&& is logical and || is logical or. && means that both conditions must be met while || means that only one of the conditions must be met.

But what is the code supposed to do?

[Xaring]

Id also welcome some indentations, mostly inside the while loop. The spacing between each "}" confuses me too

 

As you are new in this, let me tell you this: it's important to use legible and clear sintax and well explained variables, even more if you are planning to show this to anyone (us if you are searching for help). You know whats going on in the program, what are its functions, etc, for the rest of human beings, its just too braindraining having to decipher all the functionality in the code, and you can simply take 5 seconds typing 'sum needs to be m+n if "propper variable name" is less than X.' or something like so.

 

I can also see that there is no new velues for M or N being set inside the loop. It will go on forever as the conditions for it to be TRUE will always be TRUE.

[z3kron]

&& is logical and || is logical or. && means that both conditions must be met while || means that only one of the conditions must be met.

But what is the code supposed to do?

Its basicaly a calculating program with calculates m witch meanings change in the interval from 2 to -2 in a step of h1=-0.5 and n changes in an interval of 1 to 5 in a step h2=1

[79wjd]

I can also see that there is no new velues for M or N being set inside the loop. It will go on forever as the conditions for it to be TRUE will always be TRUE.

m and n are set at the end of the for loops.

[z3kron]

Id also welcome some indentations, mostly inside the while loop. The spacing between each "}" confuses me too

 

As you are new in this, let me tell you this: it's important to use legible and clear sintax and well explained variables, even more if you are planning to show this to anyone (us if you are searching for help). You know whats going on in the program, what are its functions, etc, for the rest of human beings, its just too braindraining having to decipher all the functionality in the code, and you can simply take 5 seconds typing 'sum needs to be m+n if "propper variable name" is less than X.' or something like so.

 

I can also see that there is no new velues for M or N being set inside the loop. It will go on forever as the conditions for it to be TRUE will always be TRUE.

 

&& is logical and || is logical or. && means that both conditions must be met while || means that only one of the conditions must be met.

But what is the code supposed to do?

 

Because im foreign and i learn every coding meaning in my native language its hard to understand what you want me to change.

Can any of you just fix whats wrong in this code and send it here. Leave the spacings with those } but the main thing because its just too hard for me to understand.

(

[Xaring]

Its basicaly a calculating program with calculates m witch meanings change in the interval from 2 to -2 in a step of h1=-0.5 and n changes in an interval of 1 to 5 in a step h2=1

can you give an example of the outcome? I didnt quite get it with your explanation, sorry. 

 

PS- ye i can tell english is not your native languaje (same here, im spanish) just keep trying

[z3kron]

can you give an example of the outcome? I didnt quite get it with your explanation, sorry. 

 

PS- ye i can tell english is not your native languaje (same here, im spanish) just keep trying

Ok this is my task for class.

Make a code 'a' value calculator. Every 'm' , witch values 'm' change in the interval of 2 to -2 in a step of h1=-0,5 (basicaly whatever m is it changes in the range from 2 to -2 in a step of -0.5) and values of 'n' changing in the interval of 1 to 5 in a step of h2=2 ( same thing only the interval is 1 to 5 and step is 1). This what it should do.

I'm just asking to fix my mistake witch i probably made in the code witch gives me an answer 0 no mater what number i type in in the meaning of m and n