Jump to content

Weird Behavior in C For Loop

JamesTheFolf

This program is designed to count how many vowels are in the words the user input, and the program ends when the user does CNTR+D. For some reason the last time the loop runs it always adds the last found vowel a second time.

 

So you would enter 'a' and it would say there were 2 of them.

 

#include <stdio.h>
#include <string.h>

int main(){
    
    // Creates string variable to store the users input
    char userString[64];

    // Prompts user for a string
    printf("Please enter a string that is all lowercase and less than 50 charecters\n");

    // Creates variables to store the number of each vowel in the string
    int numA = 0;
    int numE = 0;
    int numI = 0;
    int numO = 0;
    int numU = 0;

    // While loop to count how many of each vowel(s) are in the lowercase string
    while(1) {

        // Ends the program when the user enters CTRL+D
        if (feof(stdin)) break;

        // Stores the user input in userString
        scanf("%s", userString);

        for (int i = 0; userString[i] != '\0'; i++) {
            // Adds the 1 to the total number of each vowel when the vowel comes up in the string
            if (userString[i] == 'a') {
                numA += 1;
            }
            else if (userString[i] == 'e') {
                numE += 1;
            }
            else if (userString[i] == 'i') {
                numI += 1;
            }
            else if (userString[i] == 'o') {
                numO += 1;
            }
            else if (userString[i] == 'u') {
                numU += 1;
            }
        }
    }

    // Prints the output for the number of each vowel in the string
    printf("The vowel a occurred %d times\n", numA);
    printf("The vowel e occurred %d times\n", numE);
    printf("The vowel i occurred %d times\n", numI);
    printf("The vowel o occurred %d times\n", numO);
    printf("The vowel u occurred %d times\n", numU);

    // Returns a 0 to end the program
    return 0;
}

 

Link to comment
Share on other sites

Link to post
Share on other sites

47 minutes ago, jrhaberland said:

This program is designed to count how many vowels are in the words the user input, and the program ends when the user does CNTR+D. For some reason the last time the loop runs it always adds the last found vowel a second time.

 

So you would enter 'a' and it would say there were 2 of them.

I'm not super well versed in some of the C stdio functions, but if you flip the positions of the ctrl-D check and parsing for text, it will return the correct values (per my simulations).

 

EDIT: Here's what I assume is happening in the loop...

  1. Ctrl-D is checked for
  2. String is parsed
  3. String is counted

However, by the time you can enter ctrl-D, the program is already blocking on the "string is parsed" line, so it has to loop through again before the ctrl-D check, and I assume that a ctrl-D input to the parse function doesn't fully overwrite what was in the buffer, so (most of?) it gets counted again. If you do it the other way around (as I suggest), you parse input, then check if it happens to be ctrl-D before continuing to count.

Main System (Byarlant): Ryzen 7 5800X | Asus B550-Creator ProArt | EK 240mm Basic AIO | 16GB G.Skill DDR4 3200MT/s CAS-14 | XFX Speedster SWFT 210 RX 6600 | Samsung 990 PRO 2TB / Samsung 960 PRO 512GB / 4× Crucial MX500 2TB (RAID-0) | Corsair RM750X | Mellanox ConnectX-3 10G NIC | Inateck USB 3.0 Card | Hyte Y60 Case | Dell U3415W Monitor | Keychron K4 Brown (white backlight)

 

Laptop (Narrative): Lenovo Flex 5 81X20005US | Ryzen 5 4500U | 16GB RAM (soldered) | Vega 6 Graphics | SKHynix P31 1TB NVMe SSD | Intel AX200 Wifi (all-around awesome machine)

 

Proxmox Server (Veda): Ryzen 7 3800XT | AsRock Rack X470D4U | Corsair H80i v2 | 64GB Micron DDR4 ECC 3200MT/s | 4x 10TB WD Whites / 4x 14TB Seagate Exos / 2× Samsung PM963a 960GB SSD | Seasonic Prime Fanless 500W | Intel X540-T2 10G NIC | LSI 9207-8i HBA | Fractal Design Node 804 Case (side panels swapped to show off drives) | VMs: TrueNAS Scale; Ubuntu Server (PiHole/PiVPN/NGINX?); Windows 10 Pro; Ubuntu Server (Apache/MySQL)


Media Center/Video Capture (Jesta Cannon): Ryzen 5 1600X | ASRock B450M Pro4 R2.0 | Noctua NH-L12S | 16GB Crucial DDR4 3200MT/s CAS-22 | EVGA GTX750Ti SC | UMIS NVMe SSD 256GB / Seagate 1.5TB HDD | Corsair CX450M | Hauppauge ImpactVCB-PCIe | Mellanox ConnectX-2 10G NIC | LG UH12NS30 BD-ROM | Silverstone Sugo SG-11 Case | Sony XR65A80K

 

Camera: Sony ɑ7II w/ Meike Grip | Sony SEL24240 | Samyang 35mm ƒ/2.8 | Sony SEL50F18F | Sony SEL2870 (kit lens) | PNY Elite Perfomance 512GB SDXC card

 

Network:

Spoiler
                           ┌─────────────── Office/Rack ────────────────────────────────────────────────────────────────────────────┐
Google Fiber Webpass ────── UniFi Security Gateway ─── UniFi Switch 8-60W ─┬─ UniFi Switch Flex XG ═╦═ Veda (Proxmox Virtual Switch)
(500Mbps↑/500Mbps↓)                             UniFi CloudKey Gen2 (PoE) ─┴─ Veda (IPMI)           ╠═ Veda-NAS (HW Passthrough NIC)
╔═══════════════════════════════════════════════════════════════════════════════════════════════════╩═ Narrative (Asus USB 2.5G NIC)
║ ┌────── Closet ──────┐   ┌─────────────── Bedroom ──────────────────────────────────────────────────────┐
╚═ UniFi Switch Flex XG ═╤═ UniFi Switch Flex XG ═╦═ Byarlant
   (PoE)                 │                        ╠═ Narrative (Cable Matters USB-PD 2.5G Ethernet Dongle)
                         │                        ╚═ Jesta Cannon*
                         │ ┌─────────────── Media Center ──────────────────────────────────┐
Notes:                   └─ UniFi Switch 8 ─────────┬─ UniFi Access Point nanoHD (PoE)
═══ is Multi-Gigabit                                ├─ Sony Playstation 4 
─── is Gigabit                                      ├─ Pioneer VSX-S520
* = cable passed to Bedroom from Media Center       ├─ Sony XR65A80K (Google TV)
** = cable passed from Media Center to Bedroom      └─ Work Laptop** (Startech USB-PD Dock)

 

Retired/Other:

Spoiler

Laptop (Rozen-Zulu): Sony VAIO VPCF13WFX | Core i7-740QM | 8GB Patriot DDR3 | GT 425M | Samsung 850EVO 250GB SSD | Blu-ray Drive | Intel 7260 Wifi (lived a good life, retired with honor)

Testbed/Old Desktop (Kshatriya): Xeon X5470 @ 4.0GHz | ZALMAN CNPS9500 | Gigabyte EP45-UD3L | 8GB Nanya DDR2 400MHz | XFX HD6870 DD | OCZ Vertex 3 Max-IOPS 120GB | Corsair CX430M | HooToo USB 3.0 PCIe Card | Osprey 230 Video Capture | NZXT H230 Case

TrueNAS Server (La Vie en Rose): Xeon E3-1241v3 | Supermicro X10SLL-F | Corsair H60 | 32GB Micron DDR3L ECC 1600MHz | 1x Kingston 16GB SSD / Crucial MX500 500GB

Link to comment
Share on other sites

Link to post
Share on other sites

11 minutes ago, AbydosOne said:

However, by the time you can enter ctrl-D, the program is already on the "string is parsed" line, so it has to loop through again before the ctrl-D check,

Precisely this. At the beginning of loop #2, the EOF check fails, and scanf() gets called. scanf() encounters EOF, and returns without doing anything to userString. The loop continues, and parses userString again. At the beginning of loop #3, the EOF check passes, and the while loop breaks.

 

Instead of a while(true) loop, this should be the conditional check:

while(scanf("%s", userString) != EOF)

 

Link to comment
Share on other sites

Link to post
Share on other sites

I was able to fix it by doing this

    // While loop to count how many of each vowel(s) are in the lowercase string
    while(1) {

        // Stores the user input in userString
        scanf("%s", userString);

        // Ends the program when the user enters CTRL+D
        if (feof(stdin)) {
            break;
        }

Essentially just had to switch it so the scanf is before the feof(stdin) statement.

Link to comment
Share on other sites

Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×