Error meaning and how to fix it?

[AmateurBuildr]

while True:
  ag=input("\nENTER E TO REROLL\n")
  if ag=="E" or ag=="e":

    for i in range(_q):
      r1=random.choice(list2)
      list1.append(r1)
      list2.remove(r1)


  print("LOADING...")
  time.sleep(2)
  os.system("clear")
  for i in list1:  
    print(i, end="")

elif ag=="!exit":
  break

If i run this code, it gives me an error. How do i fix it and what am i doing wrong? Edit: There is more code. This is only a fracture of it.

 File "main.py", line 37
    elif ag=="!exit":
    ^^^^
SyntaxError: invalid syntax

Edited June 2, 2023 by AmateurBuildr

[johnno23]

Does your application not have a debug mode where it can run the code and then halt and identify where the error is occurring ?

Last time I messed around with code was so long ago but simple commands and scripts etc the debug window would run in an isolated window and check for errors.

[Avocado Diaboli]

You need to look at the indentation. That elif-statement isn't on the same depth as the if-statement, so the interpreter assumes you're trying to use an elif-statement without a preceding if-statement. Never mind that everything between the if- and elif-statements is probably not going to be executing the way you intend.

 

You have two options. Either indent everything between if and elif to the same depth, like this:

while True:
  ag=input("\nENTER E TO REROLL\n")
  if ag=="E" or ag=="e":
    
    for i in range(_q):
      r1=random.choice(list2)
      list1.append(r1)
      list2.remove(r1)
      
    print("LOADING...")
    time.sleep(2)
    os.system("clear")
      
    for i in list1:
      print(i, end="")
        
  elif ag=="!exit":
    break

Or you reorder the if and elif statements or turn the elif into a guard clause by basically asking if ag=="!exit" first and breaking immediately, instead of evaluating if it's "E" or "e" in the first place. Basically this:

while True:
  ag=input("\nENTER E TO REROLL\n")
  if ag=="!exit":
    break
  
  if ag=="E" or ag=="e":
    #do the rest

[wanderingfool2]

On 6/1/2023 at 11:56 PM, Avocado Diaboli said:

Or you reorder the if and elif statements or turn the elif into a guard clause by basically asking if ag=="!exit" first and breaking immediately, instead of evaluating if it's "E" or "e" in the first place. Basically this:

From a readability standpoint I would recommend the reorder option.