Robin Hood investing app forgets to check for leap year

[Cobiskuit]

Article that shows app is down, later cites bug

Reddit bug screenshot here

 

I for one find this hilarious. Thoughts?

(Mods let me know if this doesn't belong here)

[FezBoy]

RIP my SPY puts

[Ecchi]

I can't believe they didn't count for  a leap year... Bad design.

[LAwLz]

2 hours ago, Ecchi said:

I can't believe they didn't count for  a leap year... Bad design.

Coding things like leap years, leap seconds, time zones and the likes is a major pain in the ass.

Bad design, sure, but a pretty understandable oversight.

[DemiGod]

If (current Year %4 = 0)

Days Add 1 day? 

 

Don't know the entire code but doesn't seem like adding such checks overall is hard

[WkdPaul]

4 hours ago, Cobiskuit said:

Article that shows app is down, later cites bug

Reddit bug screenshot here

 

I for one find this hilarious. Thoughts?

(Mods let me know if this doesn't belong here)

Your thread doesn't follow the Tech News posting guidelines, so it was moved to the General section.

 

If you want your thread moved back, please edit it so that it follows the guidelines ;

 

[minibois]

3 hours ago, DemiGod said:

If (current Year %4 = 0)

Days Add 1 day? 

 

Don't know the entire code but doesn't seem like adding such checks overall is hard

You would need to add two more check to that, since leap years isn't just "is the year divisible by 4?".

If a year is divisible by 100, it is NOT a leap year (like the years 1800, 1900, etc.). Unless then again a year is divisible by 400, then it is a leap year (like 1600, 2000, etc.).

 

So the check needs to look a little like this:

if(((year % 4 == 0) && (year % 100 != 0)) || (year % 400 == 0))
{
	YearIsLeapYear = true;
}

Not keeping in mind those two extra rules would only result in an error in the year 2100, which may seem far away.. But so was the year 2000, when programs were still working with two number year formats.

But that still does not account for leapseconds, different timezones (like half hour or quarter of an hour timezones), etc.

 

In these sorts of circumstances it's probably best to just use a library which includes all this stuff and rigorously check (unit test) it for your purposes.

 

[themaniac]

well that's another reason to stay clear of robinhood it seems, especially after this imgur post I saw a couple days ago

Spoiler

https://imgur.com/gallery/MRPG0eY