python finding largest number

[xGear]

Evening again everyone! Pythons really trolling me this week haha....anyways the following won't work, it supposed to find the largest number out of 5 inputed numbers. It works for finding the smallest and I just reversed the signs to > and it just wont work, any suggestions appreciated. Cheers.

 

A = int(input ("Enter first number"))

B = int(input ("Enter second number"))

C = int(input ("Enter third number"))

D = int(input ("Enter fourth number"))

E = int(input ("Enter fifth number"))

 

 

if A > B:

    if A > C:

        if A > D:

            if A > E:

                print (A)

elif B > A:

    if B > C:

        if B > D:

            if B > E:

                print (B)

elif C > A:

    if C > B:

        if C > D:

            if C > E:

                print ©

elif D > A:

    if D > B:

        if D > C:

            if D > E:

                 print (D)

else:

    if E > A:

        if E > B:

            if E > C:

                if E > D:

                    print (E)

 

[xGear]

 

Evening again everyone! Pythons really trolling me this week haha....anyways the following won't work, it supposed to find the largest number out of 5 inputed numbers. It works for finding the smallest and I just reversed the signs to > and it just wont work, any suggestions appreciated. Cheers.

 

A = int(input ("Enter first number"))

B = int(input ("Enter second number"))

C = int(input ("Enter third number"))

D = int(input ("Enter fourth number"))

E = int(input ("Enter fifth number"))

 

 

if A > B:

    if A > C:

        if A > D:

            if A > E:

                print (A)

elif B > A:

    if B > C:

        if B > D:

            if B > E:

                print ( B)

elif C > A:

    if C > B:

        if C > D:

            if C > E:

                print ©

elif D > A:

    if D > B:

        if D > C:

            if D > E:

                 print (D)

else:

    if E > A:

        if E > B:

            if E > C:

                if E > D:

                    print (E)

 

mmm so it put emojes in....the prints are meant to be the letter in alphabetical order, sorry about that!

[Paralectic]

I think you shouldn't use smileys within Python code, it's not Whatsapp.

/s

[PlayStation 2]

You might need print statements for every if variable.

[Enderman]

int value = 0for x in list    if x>value        value=x

this is just a hint, not the exact answer

work wit this and you should understand a bit better how to do that

[Sauron]

That's not a very good way of doing it...

 

let's say your numbers are in a list called list.

a = 0for(i in range(list.length()))   if list[i] > a      a = list[i]print(a)

this will have the same effect in a fifth of the lines (I'm not sure I remember the syntax too well but it should be clear)

[xGear]

That's not a very good way of doing it...

 

let's say your numbers are in a list called list.

a = 0for(i in range(list.length()))   if list[i] > a      a = list[i]print(a);

this will have the same effect in a fifth of the lines (I'm not sure I remember the syntax toow ell but it shiould be clear)

I am very basic lol.....what I have should work although long winded, it worked for the negative numbers....

[madknight3]

Please use code tags.

 

edit:

 

mmm so it put emojes in....the prints are meant to be the letter in alphabetical order, sorry about that!

 

That's one of the reasons we use code tags.

[Sauron]

I am very basic lol.....what I have should work although long winded, it worked for the negative numbers....

 

the last if cycle is unnecessary regardless, if it got to that point then E is obviously the highest number. By the same logic, you can cut every if after the first one:

if A > B:    if A > C:        if A > D:            if A > E:                print (A)elif B > C:     if B > D:         if B > E:              print (B)elif C > D:     if C > E:         print (C)elif D > E:    print (D)else:   print (E)

What error does your original code give?

[xGear]

the last if cycle is unnecessary regardless, if it got to that point then E is obviously the highest number. By the same logic, you can cut every if after the first one:

if A > B:    if A > C:        if A > D:            if A > E:                print (A)elif B > C:     if B > D:         if B > E:              print (B)elif C > D:     if C > E:         print (C)elif D > E:    print (D)else:   print (E)

What error does your original code give?

Thanks....it doesn't give an error it just doesn't output anything.

[Tedster]

Thanks....it doesn't give an error it just doesn't output anything.

Ah, stupid mistake.

Example of what you need to do:

A = int(input ("Enter first number")) --what you didA = int(raw_input("Enter first number")) --what I believe you need to do

If I'm not terribly wrong

[Sauron]

Thanks....it doesn't give an error it just doesn't output anything.

 

you probably messed up one of the conditions, check it again.

 

but you should really go for the other solution, and learn to use cycles instead of multiple ifs whenever possible. now you have 5 numbers, what if you had 1000?

[madknight3]

Ah, stupid mistake.

Example of what you need to do:

A = int(input ("Enter first number")) --what you didA = int(raw_input("Enter first number")) --what I believe you need to do

If I'm not terribly wrong

 

input() is for Python 3

raw_input() is for Python 2

[fizzlesticks]

Ah, stupid mistake.

Example of what you need to do:

raw_input was renamed to just input in Python3.

 

 

edit: or you could just do

print(max([int(input('Enter {} number: '.format(['first','second','third','fourth','fifth'][x]))) for x in range(5)]))

[Tedster]

input() is for Python 3

raw_input() is for Python 2

 

 

raw_input was renamed to just input in Python3.

 

The original code didn't work because you would need to use >= instead of just >.

Ah. Our computing teacher seems to swear by Python 2 so I have no clue about Python 3.

[xGear]

 

raw_input was renamed to just input in Python3.

 

 

edit: or you just just do

print(max([int(input('Enter {} number: '.format(['first','second','third','fourth','fifth'][x]))) for x in range(5)]))

>= doesn't work either thanks

[fizzlesticks]

>= doesn't work either thanks

Ya sorry, misread and thought you had all ifs. 

 

It doesn't work because if A>B but A<C for example your code drops out of the if statements without doing anything. I'd suggest just using the max() function.

[xGear]

Ya sorry, misread and thought you had all ifs. 

 

It doesn't work because if A>B but A<C for example your code drops out of the if statements without doing anything. I'd suggest just using the max() function.

Ok thanks

[olbaze]

What you should be doing is saving the inputs in a list. Then you can sort the list and print the last element, which will be the largest.

[madknight3]

I would also recommend learning about boolean operations.

# Your code becomes this (with the logical errors fixed)if A >= B and A >= C and A >= D and A >= E:    print (A)elif B >= A and B >= C and B >= D and B >= E:    print (B)elif C >= A and C >= B and C >= D and C >= E:    print (C)elif D >= A and D >= B and D >= C and D >= E:    print (D)elif E >= A and E >= B and E >= C and E >= D:    print (E)

There are still better ways of getting the max value, however this will at least help you learn a bit more about working with if statements and booleans.

[fizzlesticks]

--snip--

Will still fail if 2 of the values are both the max.

[madknight3]

Will still fail if 2 of the values are both the max.

 

Whoops...I'll have to edit it.

[vorticalbox]

Come on guys all ifs? 

 

best way is to store the numbers in an array and use loops to bubble sort.

 

here is it in c# i don't know python

int[] numbers = new int[] {1, 5, 3, 4, 2};foreach(int nums in numbers){    for(int i=0;i < numbers.Length-1;i++)    {        int temp;                if(numbers[i] > numbers[i+1])        {            temp = numbers[i+1];            numbers[i+1] = numbers[i];            numbers[i] = temp;        }    }}foreach(int nu in numbers){ Console.WriteLine(nu);}

Output

 

1,2,3,4,5

 

or as you need just print out the highest number as it will always been at the end of the array 

[madknight3]

Come on guys all ifs?

 

If the goal is to understand how if statements and boolean expressions work, then sure, it's an acceptable exercise.

 

Alternatives were also mentioned, including sorting, which isn't the "best way" in many cases.

[vorticalbox]

If the goal is to understand how if statements and boolean expressions work, then sure, it's an acceptable exercise.

 

Alternatives were also mentioned, including sorting, which isn't the "best way" in many cases.

I guess, sorting seems better then having lots of ifs, simple options tend to be better.