Could we make a thread specifically about bad practices?

[Exgaves]

using public variables in a class

 

always use accessors/mutators 

[Avratz]

#define struct union

[Opcode]

Using

break;

is a bad practice....or so every professor i've had likes to say--although It certainly has its merits. 

Definitely not so. In a switch or loop statement this can cut down on wasted CPU cycles.

[79wjd]

Definitely not so. In a switch or loop statement this can cut down on wasted CPU cycles.

It has its uses, but it's generally considered bad style, and can often be easily avoided. 

[kingdorian]

using public variables in a class

 

always use accessors/mutators 

A lot of IDE's can even autogenerate them for you...

[Exgaves]

A lot of IDE's can even autogenerate them for you...

that in itself is also kind of a bad practice

 

code generated by IDE's is something to be careful of, especially for learners who end up taking it for granted and don't fully understand their purpose

[kingdorian]

that in itself is also kind of a bad practice

 

code generated by IDE's is something to be careful of, especially for learners who end up taking it for granted and don't fully understand their purpose

Always check it yourself (and almost always you have to make some ajustments) but I don't think it is a bad practice per se.

private int number;public int getNumber(){        return number;}

There is not very much that can go wrong in cases like this but it saves you another 5 minutes if you have a couple of variables. I'm not talking about things like toString or "even" more complex methods/functions.

[Opcode]

It has its uses, but it's generally considered bad style, and can often be easily avoided. 

Indeed there are better ways of doing it rather than using a break after every case statement. As it would generate a lot of extra lines of code that are not needed.

[Exgaves]

Always check it yourself (and almost always you have to make some ajustments) but I don't think it is a bad practice per se.

private int number;public int getNumber(){        return number;}

There is not very much that can go wrong in cases like this but it saves you another 5 minutes if you have a couple of variables. I'm not talking about things like toString or "even" more complex methods/functions.

I'm talking about why getters/setters are used, and why you should create proper class interfaces and not just let classes access variables directly, people dont realise the importance of encapsulation, etc early on and they create bad habbits